Remove OriginatingProcess and RendererProcess overloads [chromium/src : main]

0 views
Skip to first unread message

Kenichi Ishibashi (Gerrit)

unread,
Feb 24, 2026, 6:41:24 PM (7 days ago) Feb 24
to Christopher Staite, Takashi Toyoshima, chromium...@chromium.org, network-ser...@chromium.org
Attention needed from Christopher Staite and Takashi Toyoshima

Kenichi Ishibashi voted and added 1 comment

Votes added by Kenichi Ishibashi

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kenichi Ishibashi . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Christopher Staite
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
Gerrit-Change-Number: 7603876
Gerrit-PatchSet: 1
Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 23:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Feb 25, 2026, 5:13:06 AM (6 days ago) Feb 25
to Christopher Staite, Kenichi Ishibashi, chromium...@chromium.org, network-ser...@chromium.org
Attention needed from Christopher Staite

Takashi Toyoshima voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christopher Staite
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
    Gerrit-Change-Number: 7603876
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>
    Gerrit-Comment-Date: Wed, 25 Feb 2026 10:12:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Christopher Staite (Gerrit)

    unread,
    Feb 25, 2026, 5:20:34 AM (6 days ago) Feb 25
    to Takashi Toyoshima, Kenichi Ishibashi, chromium...@chromium.org, network-ser...@chromium.org

    Christopher Staite added 1 comment

    Patchset-level comments
    Christopher Staite . resolved

    Thank you. If I could bother you for a CQ+2 please that would be appreciated.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
    Gerrit-Change-Number: 7603876
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Wed, 25 Feb 2026 10:20:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Kenichi Ishibashi (Gerrit)

    unread,
    Feb 26, 2026, 7:10:18 PM (5 days ago) Feb 26
    to Christopher Staite, Takashi Toyoshima, chromium...@chromium.org, network-ser...@chromium.org
    Attention needed from Christopher Staite

    Kenichi Ishibashi voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christopher Staite
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
    Gerrit-Change-Number: 7603876
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 00:09:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Christopher Staite (Gerrit)

    unread,
    Feb 27, 2026, 4:43:52 AM (4 days ago) Feb 27
    to Chromium LUCI CQ, Kenichi Ishibashi, Takashi Toyoshima, chromium...@chromium.org, network-ser...@chromium.org

    Christopher Staite added 1 comment

    Patchset-level comments
    Christopher Staite . resolved

    Sneaky one got in to main before I could merge. Annoyingly I think it was from one of my own other CLs.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
    Gerrit-Change-Number: 7603876
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 09:43:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    Feb 27, 2026, 5:34:55 AM (4 days ago) Feb 27
    to Christopher Staite, Chromium LUCI CQ, Kenichi Ishibashi, chromium...@chromium.org, network-ser...@chromium.org
    Attention needed from Christopher Staite and Kenichi Ishibashi

    Takashi Toyoshima voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christopher Staite
    • Kenichi Ishibashi
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
      Gerrit-Change-Number: 7603876
      Gerrit-PatchSet: 2
      Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
      Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
      Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>
      Gerrit-Comment-Date: Fri, 27 Feb 2026 10:34:19 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Takashi Toyoshima (Gerrit)

      unread,
      Feb 27, 2026, 5:35:07 AM (4 days ago) Feb 27
      to Christopher Staite, Chromium LUCI CQ, Kenichi Ishibashi, chromium...@chromium.org, network-ser...@chromium.org
      Attention needed from Christopher Staite and Kenichi Ishibashi

      Takashi Toyoshima voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Fri, 27 Feb 2026 10:34:43 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kenichi Ishibashi (Gerrit)

      unread,
      Feb 27, 2026, 5:46:23 AM (4 days ago) Feb 27
      to Christopher Staite, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, network-ser...@chromium.org
      Attention needed from Christopher Staite and Takashi Toyoshima

      Kenichi Ishibashi voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christopher Staite
      • Takashi Toyoshima
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
        Gerrit-Change-Number: 7603876
        Gerrit-PatchSet: 2
        Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
        Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
        Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>
        Gerrit-Comment-Date: Fri, 27 Feb 2026 10:45:52 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Feb 27, 2026, 6:45:15 AM (4 days ago) Feb 27
        to Christopher Staite, Kenichi Ishibashi, Takashi Toyoshima, chromium...@chromium.org, network-ser...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Remove OriginatingProcess and RendererProcess overloads

        In order to make merging the CL renaming these interfaces easier,
        overloads were added for `network::OriginatingProcess` and
        `network::RendererProcess`. These are no longer required and are
        therefore may be removed.
        Bug: 379869738
        Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
        Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
        Commit-Queue: Kenichi Ishibashi <ba...@chromium.org>
        Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1591467}
        Files:
        • M content/browser/network_service_instance_impl_unittest.cc
        • M services/network/public/cpp/originating_process_id.h
        • M services/network/public/cpp/renderer_process_id.h
        Change size: XS
        Delta: 3 files changed, 1 insertion(+), 7 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Takashi Toyoshima, +1 by Kenichi Ishibashi
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I62efe92385ea6ef214a755167d53add5a3984d96
        Gerrit-Change-Number: 7603876
        Gerrit-PatchSet: 3
        Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
        Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages