Add network::DataElementBytes::AsStringView() [chromium/src : main]

0 views

Skip to first unread message

Daniel Cheng (Gerrit)

unread,

Sep 6, 2025, 5:14:21 AM (3 days ago) Sep 6

to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, network-ser...@chromium.org

Attention needed from Lei Zhang

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Daniel Cheng . unresolved

Since we're changing this anyway, and the callers appear to only be tests... should this actually be something like "as_byte_span()"? Because at least in some places, it seems like it's really bytes.

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages