Speculative fix for another BadMessage class in RCM. [chromium/src : main]
0 views
Skip to first unread message
Maks Orlovich (Gerrit)
Feb 27, 2026, 2:13:53 PM (4 days ago) Feb 27
to Chris Fredrickson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Attention needed from Chris Fredrickson
Maks Orlovich added 1 comment![]( "Open in Gerrit")
File services/network/restricted_cookie_manager.cc
Line 933, Patchset 2 (Latest):
}Maks Orlovich . unresolved
This would be cleaner in cookie_store, but actual OWNERs are OoO or in Tokyo, which makes review timing a mess...
Related details
Attention is currently required from:
- Chris Fredrickson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Fredrickson (Gerrit)
Feb 27, 2026, 2:43:25 PM (4 days ago) Feb 27
to Maks Orlovich, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Attention needed from Maks Orlovich
Chris Fredrickson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Chris Fredrickson
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Chris Fredrickson . resolved
Weird. Speculative fix LGTM, can we add a regression test? I'm fine with doing that in a followup so that this fix can land quicker.
File services/network/restricted_cookie_manager.cc
This would be cleaner in cookie_store, but actual OWNERs are OoO or in Tokyo, which makes review timing a mess...
Attention is currently required from:
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Feb 27, 2026, 2:48:09 PM (4 days ago) Feb 27
to Chris Fredrickson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Maks Orlovich voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maks Orlovich
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Chris Fredrickson . resolved
Weird. Speculative fix LGTM, can we add a regression test? I'm fine with doing that in a followup so that this fix can land quicker.
Maks Orlovich
I have no idea as to how we ever get in this state, so I can't really guarantee it.
(The reason I am e-mailing this now is that I spent the morning trying, and failed, and figured I should do mitigation somewhat earlier than 5PM on a Friday).
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Feb 27, 2026, 2:49:44 PM (4 days ago) Feb 27
to Chris Fredrickson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Maks Orlovich voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 27, 2026, 3:14:21 PM (4 days ago) Feb 27
to Maks Orlovich, Chris Fredrickson, AyeAye, chromium...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Speculative fix for another BadMessage class in RCM.
We somehow receive listener add requests with an empty
URL. I am not sure how we get into this state, but reports
in wild and release schedule require a rapid response, so
just ignore this case; that's behaviorally correct anyway.
The origin in the renderer probably isn't opaque since there is
a report on 147.0.7703.0
Bug: 488084020
Change-Id: I3a83570e2ba24c01a4eb0c9c2c30b8794c2544c7
Commit-Queue: Maks Orlovich <morl...@chromium.org>
Reviewed-by: Chris Fredrickson <cfre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1591734}
Files:
- M services/network/restricted_cookie_manager.cc
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Fredrickson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages