Remove launched compression dictionary feature flags [chromium/src : main]

0 views
Skip to first unread message

Patrick Meenan (Gerrit)

unread,
Sep 5, 2025, 7:22:36 PM (3 days ago) Sep 5
to Tsuyoshi Horo, Yoav Weiss (@Shopify), AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Nate Chapin, James Maclean, prerenderi...@chromium.org, gavinp+p...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, dullweb...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Tsuyoshi Horo

Patrick Meenan added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Patrick Meenan . resolved

horo@ could you PTAL? This is a first pass at cleaning up the compression dictionary feature flags.

Open in Gerrit

Related details

Attention is currently required from:
  • Tsuyoshi Horo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iec9033d3a3d523480a044e1c7de5056cb65ed540
Gerrit-Change-Number: 6920427
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Meenan <pme...@chromium.org>
Gerrit-Reviewer: Patrick Meenan <pme...@chromium.org>
Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 23:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tsuyoshi Horo (Gerrit)

unread,
Sep 7, 2025, 9:41:29 PM (20 hours ago) Sep 7
to Patrick Meenan, Yoav Weiss (@Shopify), AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Nate Chapin, James Maclean, prerenderi...@chromium.org, gavinp+p...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, dullweb...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Patrick Meenan

Tsuyoshi Horo voted and added 1 comment

Votes added by Tsuyoshi Horo

Code-Review+1

1 comment

Patchset-level comments
Tsuyoshi Horo . resolved

lgtm
Thank you very much!

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Meenan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec9033d3a3d523480a044e1c7de5056cb65ed540
    Gerrit-Change-Number: 6920427
    Gerrit-PatchSet: 3
    Gerrit-Owner: Patrick Meenan <pme...@chromium.org>
    Gerrit-Reviewer: Patrick Meenan <pme...@chromium.org>
    Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Patrick Meenan <pme...@chromium.org>
    Gerrit-Comment-Date: Mon, 08 Sep 2025 01:41:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Patrick Meenan (Gerrit)

    unread,
    11:49 AM (5 hours ago) 11:49 AM
    to Kouhei Ueno, Christian Dullweber, Tommy Nyquist, Tsuyoshi Horo, Yoav Weiss (@Shopify), AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Nate Chapin, James Maclean, prerenderi...@chromium.org, gavinp+p...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, chasej...@chromium.org, dullweb...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Christian Dullweber, Kouhei Ueno and Tommy Nyquist

    Patrick Meenan added 1 comment

    Patchset-level comments
    Patrick Meenan . resolved

    kouhei@ Could you PTAL at the files that horo@ couldn't owner-approve?

    dullweber@ could you PTAL at the **/browsing_data/** files?

    nyquist@ could you PTAL at chrome/browser/policy/test/shared_dictionary_policy_browsertest.cc?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christian Dullweber
    • Kouhei Ueno
    • Tommy Nyquist
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec9033d3a3d523480a044e1c7de5056cb65ed540
    Gerrit-Change-Number: 6920427
    Gerrit-PatchSet: 3
    Gerrit-Owner: Patrick Meenan <pme...@chromium.org>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Patrick Meenan <pme...@chromium.org>
    Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>
    Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
    Gerrit-Attention: Tommy Nyquist <nyq...@chromium.org>
    Gerrit-Comment-Date: Mon, 08 Sep 2025 15:49:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages