[Enterprise] Update policy description and add tests [chromium/src : main]

Skip to first unread message

Jan Zarzycki (Gerrit)

unread,
Apr 1, 2026, 8:50:27 AM (3 days ago) Apr 1
to Igor Ruvinov, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Igor Ruvinov

Jan Zarzycki added 1 comment

Patchset-level comments
File-level comment, Patchset 2:
Jan Zarzycki . resolved

I think that issue described in bug was caused by invalid value specified in policy value which was not using [URL blocklist filter format](https://support.google.com/chrome/a/answer/9942583?visit_id=639106413840124234-777735865&p=url_blocklist_filter_format&rd=1). I added unit test to verify that it works when value is using blocklist format and port is specified. I also updated policy description and example values to use correct format.

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Ruvinov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic41b64e40508ae1e977caf111932eeca08fe84c3
Gerrit-Change-Number: 7719099
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Zarzycki <janza...@google.com>
Gerrit-Reviewer: Igor Ruvinov <igorr...@chromium.org>
Gerrit-Reviewer: Jan Zarzycki <janza...@google.com>
Gerrit-Attention: Igor Ruvinov <igorr...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 12:50:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Igor Ruvinov (Gerrit)

unread,
Apr 1, 2026, 10:45:08 AM (3 days ago) Apr 1
to Jan Zarzycki, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Jan Zarzycki

Igor Ruvinov voted and added 1 comment

Votes added by Igor Ruvinov

Code-Review+1

1 comment

File services/network/network_context_unittest.cc
Line 9910, Patchset 3 (Latest): const GURL kGoogle("https://google.com");
Igor Ruvinov . unresolved

Nit: could we cover the scheme as well by adding a URL with `http://`?

Open in Gerrit

Related details

Attention is currently required from:
  • Jan Zarzycki
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic41b64e40508ae1e977caf111932eeca08fe84c3
    Gerrit-Change-Number: 7719099
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jan Zarzycki <janza...@google.com>
    Gerrit-Reviewer: Igor Ruvinov <igorr...@chromium.org>
    Gerrit-Reviewer: Jan Zarzycki <janza...@google.com>
    Gerrit-Attention: Jan Zarzycki <janza...@google.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 14:44:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jan Zarzycki (Gerrit)

    unread,
    Apr 2, 2026, 7:04:33 AM (2 days ago) Apr 2
    to Igor Ruvinov, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org

    Jan Zarzycki added 1 comment

    File services/network/network_context_unittest.cc
    Line 9910, Patchset 3: const GURL kGoogle("https://google.com");
    Igor Ruvinov . resolved

    Nit: could we cover the scheme as well by adding a URL with `http://`?

    Jan Zarzycki

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic41b64e40508ae1e977caf111932eeca08fe84c3
      Gerrit-Change-Number: 7719099
      Gerrit-PatchSet: 5
      Gerrit-Owner: Jan Zarzycki <janza...@google.com>
      Gerrit-Reviewer: Igor Ruvinov <igorr...@chromium.org>
      Gerrit-Reviewer: Jan Zarzycki <janza...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 11:04:14 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Igor Ruvinov <igorr...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages