Add DevToolsIndividualRequestThrottling flag [chromium/src : main]
0 views
Skip to first unread message
Philip Pfaffe (Gerrit)
Sep 4, 2025, 8:24:01 AM (4 days ago) Sep 4
to Alex Rudenko, Daniel Cheng, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko and Daniel Cheng
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Philip Pfaffe . resolved
Gemini helped with this CL.
Daniel: PTAL at //services
Alex: PTAL at the rest
Thanks!
Related details
Attention is currently required from:
- Alex Rudenko
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Sep 4, 2025, 8:25:35 AM (4 days ago) Sep 4
to Philip Pfaffe, Daniel Cheng, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng and Philip Pfaffe
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/features.cc
Line 671, Patchset 3 (Latest):
BASE_FEATURE(kDevToolsIndividualRequestThrottling,Alex Rudenko . unresolved
any reason not to have the feature in chrome/browser/devtools/features.cc?
Related details
Attention is currently required from:
- Daniel Cheng
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Sep 4, 2025, 8:26:00 AM (4 days ago) Sep 4
to Philip Pfaffe, Daniel Cheng, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng and Philip Pfaffe
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Sep 4, 2025, 8:29:09 AM (4 days ago) Sep 4
to Alex Rudenko, Daniel Cheng, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko and Daniel Cheng
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/features.cc
Line 671, Patchset 3 (Latest):
BASE_FEATURE(kDevToolsIndividualRequestThrottling,Alex Rudenko . unresolved
any reason not to have the feature in chrome/browser/devtools/features.cc?
Attention is currently required from:
- Alex Rudenko
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Sep 4, 2025, 8:31:19 AM (4 days ago) Sep 4
to Philip Pfaffe, Daniel Cheng, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng and Philip Pfaffe
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/features.cc
Line 671, Patchset 3 (Latest):
BASE_FEATURE(kDevToolsIndividualRequestThrottling,Alex Rudenko . unresolved
Philip Pfaffeany reason not to have the feature in chrome/browser/devtools/features.cc?
can //services depend on //chrome/browser?
Alex Rudenko
No, I do not think so but we could use the devtools feature flag to configure the network service in the way we need without the need for the flag to live in the network service?
Related details
Attention is currently required from:
- Daniel Cheng
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Sep 4, 2025, 8:32:31 AM (4 days ago) Sep 4
to Alex Rudenko, Daniel Cheng, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng and Philip Pfaffe
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/features.cc
Line 671, Patchset 3 (Latest):
BASE_FEATURE(kDevToolsIndividualRequestThrottling,Alex Rudenko . unresolved
Philip Pfaffeany reason not to have the feature in chrome/browser/devtools/features.cc?
can //services depend on //chrome/browser?
Philip Pfaffe
Ah, I was planning to also guard the pattern matching usage in the network service with this flag. I don't have strong feelings about that though.
Philip Pfaffe (Gerrit)
Sep 4, 2025, 8:46:59 AM (4 days ago) Sep 4
to Alex Rudenko, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/features.cc
Line 671, Patchset 3:
BASE_FEATURE(kDevToolsIndividualRequestThrottling,Alex Rudenko . unresolved
Philip Pfaffeany reason not to have the feature in chrome/browser/devtools/features.cc?
Philip Pfaffecan //services depend on //chrome/browser?
Ah, I was planning to also guard the pattern matching usage in the network service with this flag. I don't have strong feelings about that though.
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Sep 4, 2025, 8:47:04 AM (4 days ago) Sep 4
to Alex Rudenko, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko
Philip Pfaffe voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Alex Rudenko (Gerrit)
Sep 4, 2025, 8:49:37 AM (4 days ago) Sep 4
to Philip Pfaffe, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Philip Pfaffe
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Sep 4, 2025, 12:13:08 PM (4 days ago) Sep 4
to Philip Pfaffe, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Philip Pfaffe
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File services/network/public/cpp/features.cc
Line 671, Patchset 3:
BASE_FEATURE(kDevToolsIndividualRequestThrottling,Alex Rudenko . resolved
Philip Pfaffeany reason not to have the feature in chrome/browser/devtools/features.cc?
Philip Pfaffecan //services depend on //chrome/browser?
Philip PfaffeAh, I was planning to also guard the pattern matching usage in the network service with this flag. I don't have strong feelings about that though.
Moved it over! Lost the +1 though :)
Alex Rudenko
Done
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Sep 4, 2025, 12:47:39 PM (4 days ago) Sep 4
to Alex Rudenko, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Philip Pfaffe voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 12:51:09 PM (4 days ago) Sep 4
to Philip Pfaffe, Alex Rudenko, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add DevToolsIndividualRequestThrottling flag
Bug: 40434685
Change-Id: I8800a14494125148a0e18f81e9c3b7376504baf6
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Auto-Submit: Philip Pfaffe <pfa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1510972}
Files:
- M chrome/browser/about_flags.cc
- M chrome/browser/devtools/devtools_ui_bindings.cc
- M chrome/browser/devtools/features.cc
- M chrome/browser/devtools/features.h
- M chrome/browser/flag-metadata.json
- M chrome/browser/flag_descriptions.cc
- M chrome/browser/flag_descriptions.h
- M tools/metrics/histograms/enums.xml
Change size: S
Delta: 8 files changed, 34 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages