[M148] Revert "Report mojo bad message for incorrect site_for_cookies and top_frame_origin" [chromium/src : refs/branch-heads/7766]

0 views
Skip to first unread message

Krishna Govind (Gerrit)

unread,
Apr 1, 2026, 2:40:56 PM (3 days ago) Apr 1
to Lily Chen, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Lily Chen

Krishna Govind voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lily Chen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7766
Gerrit-Change-Id: If36ca6e057bd44b3737ed85a0980ebd9e5f33ef1
Gerrit-Change-Number: 7722498
Gerrit-PatchSet: 1
Gerrit-Owner: Lily Chen <chl...@chromium.org>
Gerrit-Reviewer: Krishna Govind <gov...@chromium.org>
Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
Gerrit-Attention: Lily Chen <chl...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 18:40:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Krishna Govind (Gerrit)

unread,
Apr 1, 2026, 2:41:11 PM (3 days ago) Apr 1
to Lily Chen, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org

Krishna Govind submitted the change

Change information

Commit message:
[M148] Revert "Report mojo bad message for incorrect site_for_cookies and top_frame_origin"

This reverts commit 225000ab6d13272cf32d41ea8cdba1ff65835a86.

Reason for revert: crashes from this change block release; root cause of
inconsistencies is not resolved yet so killing the renderer is not safe
for stability.

Original change's description:
> Report mojo bad message for incorrect site_for_cookies and top_frame_origin
>
> RestrictedCookieManager now explicitly reports a bad message and
> terminates the connection if the renderer provides an incorrect
> site_for_cookies or top_frame_origin. Previously, these mismatches
> were only logged as errors without further action.
>
> This change ensures that inconsistencies between the renderer's
> provided context and the browser's bound state are treated as
> protocol violations.
>
> Fixed: 495405493
> Change-Id: Ifcecd1250f4fc9d5015369ac9df7914e317d8974
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7707502
> Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
> Commit-Queue: Yoichi Osato <yoi...@chromium.org>
> Reviewed-by: Charlie Reis <cr...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1607622}

(cherry picked from commit c243f51102a4b8fe850ebb1757861e277bc8052b)
Bug: 495405493
Bug: 498312859
Change-Id: If36ca6e057bd44b3737ed85a0980ebd9e5f33ef1
Auto-Submit: Lily Chen <chl...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Lily Chen <chl...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1608684}
Reviewed-by: Krishna Govind <gov...@chromium.org>
Owners-Override: Krishna Govind <gov...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7766@{#5}
Cr-Branched-From: cc10483432346c1df9714af01aee321636072e6f-refs/heads/main@{#1607787}
Files:
  • M services/network/restricted_cookie_manager.cc
  • M services/network/restricted_cookie_manager_unittest.cc
Change size: M
Delta: 2 files changed, 15 insertions(+), 40 deletions(-)
Branch: refs/branch-heads/7766
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Krishna Govind
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7766
Gerrit-Change-Id: If36ca6e057bd44b3737ed85a0980ebd9e5f33ef1
Gerrit-Change-Number: 7722498
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages