[Connection Allowlist] Record the policy's URL. [chromium/src : main]
0 views
Skip to first unread message
Mike West (Gerrit)
Mar 31, 2026, 2:21:04 PM (4 days ago) Mar 31
to Kenichi Ishibashi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, fenced-fra...@chromium.org, ipc-securi...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi
Mike West added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mike West . resolved
Can you take a look at this CL, bashi@? The goal is to get the reporting CL you already reviewed actually working. To that end, we need to pass in the URL of the context from which the report is being sent so that it's aggregated correctly and will be sent when the document's lifecycle ends. This CL captures the URL at the point where we're parsing the headers, and carries it along through to the point in the network service where it will be used. WDYT?
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Apr 2, 2026, 12:58:06 AM (2 days ago) Apr 2
to Mike West, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, fenced-fra...@chromium.org, ipc-securi...@chromium.org, network-ser...@chromium.org
Attention needed from Mike West
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Apr 2, 2026, 1:48:51 AM (2 days ago) Apr 2
to Kenichi Ishibashi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, fenced-fra...@chromium.org, ipc-securi...@chromium.org, network-ser...@chromium.org
Mike West voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 2:39:20 AM (2 days ago) Apr 2
to Mike West, Kenichi Ishibashi, AyeAye, chromium...@chromium.org, fenced-fra...@chromium.org, ipc-securi...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Connection Allowlist] Record the policy's URL.
In order to correctly build a violation report, we need to include the
URL of the document which asserted a policy. We can do so by recording
the URL when parsing the policy, making it available for use later.
Bug: 482728970
Change-Id: I1bd5a309e882147709979f007c45d923f135f672
Commit-Queue: Mike West <mk...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608987}
Files:
- M services/network/network_context.cc
- M services/network/network_context.h
- M services/network/network_context_unittest.cc
- M services/network/public/cpp/BUILD.gn
- M services/network/public/cpp/connection_allowlist.h
- M services/network/public/cpp/connection_allowlist_mojom_traits.cc
- M services/network/public/cpp/connection_allowlist_mojom_traits.h
- M services/network/public/cpp/connection_allowlist_parser.cc
- M services/network/public/cpp/connection_allowlist_unittest.cc
- M services/network/public/mojom/BUILD.gn
- M services/network/public/mojom/connection_allowlist.mojom
Change size: M
Delta: 11 files changed, 55 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kenichi Ishibashi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages