Revert "Report mojo bad message for incorrect site_for_cookies and top_frame_origin" [chromium/src : main]
0 views
Skip to first unread message
Lily Chen (Gerrit)
Apr 1, 2026, 1:08:04 PM (3 days ago) Apr 1
to Lily Chen, Maks Orlovich, Charlie Reis, AyeAye, Rubber Stamper, Chromium LUCI CQ, Kenichi Ishibashi, Yoichi Osato, chromium...@chromium.org, network-ser...@chromium.org
Attention needed from Maks Orlovich
Lily Chen voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Apr 1, 2026, 1:08:19 PM (3 days ago) Apr 1
to Lily Chen, Maks Orlovich, Charlie Reis, AyeAye, Chromium LUCI CQ, Kenichi Ishibashi, Yoichi Osato, chromium...@chromium.org, network-ser...@chromium.org
Attention needed from Maks Orlovich
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 1, 2026, 2:31:41 PM (3 days ago) Apr 1
to Lily Chen, Rubber Stamper, Maks Orlovich, Charlie Reis, AyeAye, Kenichi Ishibashi, Yoichi Osato, chromium...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Report mojo bad message for incorrect site_for_cookies and top_frame_origin"
This reverts commit 225000ab6d13272cf32d41ea8cdba1ff65835a86.
Reason for revert: crashes from this change block release; root cause of
inconsistencies is not resolved yet so killing the renderer is not safe
for stability.
Original change's description:
> Report mojo bad message for incorrect site_for_cookies and top_frame_origin
>
> RestrictedCookieManager now explicitly reports a bad message and
> terminates the connection if the renderer provides an incorrect
> site_for_cookies or top_frame_origin. Previously, these mismatches
> were only logged as errors without further action.
>
> This change ensures that inconsistencies between the renderer's
> provided context and the browser's bound state are treated as
> protocol violations.
>
> Fixed: 495405493
> Change-Id: Ifcecd1250f4fc9d5015369ac9df7914e317d8974
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7707502
> Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
> Commit-Queue: Yoichi Osato <yoi...@chromium.org>
> Reviewed-by: Charlie Reis <cr...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1607622}
Bug: 495405493
Bug: 498312859
Change-Id: If36ca6e057bd44b3737ed85a0980ebd9e5f33ef1
Auto-Submit: Lily Chen <chl...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Lily Chen <chl...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1608684}
Files:
- M services/network/restricted_cookie_manager.cc
- M services/network/restricted_cookie_manager_unittest.cc
Change size: M
Delta: 2 files changed, 15 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages