Yoichi Osato (Gerrit)

unread,

Jan 29, 2026, 4:25:07 AMJan 29

to Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Kenichi Ishibashi

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Kenichi Ishibashi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kenichi Ishibashi (Gerrit)

unread,

Jan 29, 2026, 7:50:09 PMJan 29

to Yoichi Osato, Nicolas Ouellet-Payeur, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Nicolas Ouellet-Payeur and Yoichi Osato

Kenichi Ishibashi added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Kenichi Ishibashi . resolved

Hmm, my understanding is that we intentionally avoids strings to avoid binary bloat. +12k for debugging is probably unacceptable. Adding nico...@chromium.org to confirm.

We have a script to convert hash to string. For the bug case:
```
$ vpython3 tools/traffic_annotation/scripts/auditor/hashes.py | grep 114234406
kiosk_app_icon 114234406
```

Is it sufficient for debugging?

Open in Gerrit

Related details

Attention is currently required from:

Nicolas Ouellet-Payeur
Yoichi Osato

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kenichi Ishibashi (Gerrit)

unread,

Jan 29, 2026, 7:54:08 PMJan 29

to Yoichi Osato, Nicolas Ouellet-Payeur, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Nicolas Ouellet-Payeur and Yoichi Osato

Kenichi Ishibashi added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Kenichi Ishibashi . unresolved

Hmm, my understanding is that we intentionally avoids strings to avoid binary bloat. +12k for debugging is probably unacceptable. Adding nico...@chromium.org to confirm.
We have a script to convert hash to string. For the bug case:
```
$ vpython3 tools/traffic_annotation/scripts/auditor/hashes.py | grep 114234406
kiosk_app_icon 114234406
```
Is it sufficient for debugging?

Kenichi Ishibashi

(opening)

Open in Gerrit

Related details

Attention is currently required from:

Nicolas Ouellet-Payeur
Yoichi Osato

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yoichi Osato (Gerrit)

unread,

Jan 29, 2026, 7:59:44 PMJan 29

to Nicolas Ouellet-Payeur, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Kenichi Ishibashi and Nicolas Ouellet-Payeur

Yoichi Osato added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Kenichi Ishibashi . resolved

Hmm, my understanding is that we intentionally avoids strings to avoid binary bloat. +12k for debugging is probably unacceptable. Adding nico...@chromium.org to confirm.
We have a script to convert hash to string. For the bug case:
```
$ vpython3 tools/traffic_annotation/scripts/auditor/hashes.py | grep 114234406
kiosk_app_icon 114234406
```
Is it sufficient for debugging?

Yoichi Osato

Ah, that's nice. Let me change the ReportBadMessage just output the id instead of the string.

Open in Gerrit

Related details

Attention is currently required from:

Kenichi Ishibashi
Nicolas Ouellet-Payeur

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nicolas Ouellet-Payeur (Gerrit)

unread,

Jan 30, 2026, 9:47:16 AMJan 30

to Yoichi Osato, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Attention needed from Yoichi Osato

Nicolas Ouellet-Payeur added 2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Kenichi Ishibashi . unresolved

Hmm, my understanding is that we intentionally avoids strings to avoid binary bloat. +12k for debugging is probably unacceptable. Adding nico...@chromium.org to confirm.
We have a script to convert hash to string. For the bug case:
```
$ vpython3 tools/traffic_annotation/scripts/auditor/hashes.py | grep 114234406
kiosk_app_icon 114234406
```
Is it sufficient for debugging?

Yoichi Osato

Ah, that's nice. Let me change the ReportBadMessage just output the id instead of the string.

Nicolas Ouellet-Payeur

Hmm, my understanding is that we intentionally avoids strings to avoid binary bloat. +12k for debugging is probably unacceptable. Adding nico...@chromium.org to confirm.

Correct. IIRC there was also a concern around the runtime cost of passing the string with each request. I don't think we ever benchmarked it.

12.7KiB is a *little* large... this won't(?) be used often, and we already have a two-way mapping in the form of `hashes.py`. So probably not worth it IMO

If the problem is that `hashes.py` is not discoverable enough, maybe we can try a slightly different approach that doesn't affect binary size? Like adding the hashed ID in `annotations.xml`, so you can trivially find it with codesearch.

File services/network/cors/cors_url_loader_factory.cc

Line 614, Patchset 10 (Latest):

                      "traffic_annotation_id=",
                      traffic_annotation.unique_id}));

Nicolas Ouellet-Payeur . unresolved

if we use the hash instead: maybe mention `hashes.py` in this message, so it's more discoverable

Open in Gerrit

Related details

Attention is currently required from:

Yoichi Osato

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yoichi Osato (Gerrit)

unread,

Feb 25, 2026, 11:11:44 PM (6 days ago) Feb 25

to Nicolas Ouellet-Payeur, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

Yoichi Osato abandoned this change.

View Change

Abandoned

Yoichi Osato abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Include id string in network traffic annotation tags [chromium/src : main]

Yoichi Osato (Gerrit)

New activity on the change

Related details

Kenichi Ishibashi (Gerrit)

Kenichi Ishibashi added 1 comment

Related details

Kenichi Ishibashi (Gerrit)

Kenichi Ishibashi added 1 comment

Related details

Yoichi Osato (Gerrit)

Yoichi Osato added 1 comment

Related details

Nicolas Ouellet-Payeur (Gerrit)

Nicolas Ouellet-Payeur added 2 comments

Related details

Yoichi Osato (Gerrit)

Yoichi Osato abandoned this change

Related details