Remove deprecated base::JSONWriter::Write() calls in //services [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
Sep 4, 2025, 5:01:12 PM (4 days ago) Sep 4
to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang
Daniel Cheng added 1 comment![]( "Open in Gerrit")
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 222, Patchset 4 (Latest):
CHECK(json_value.has_value());Daniel Cheng . unresolved
Should we have this `CHECK()` given the `value_or` below?
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 4, 2025, 5:16:48 PM (4 days ago) Sep 4
to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang added 1 comment![]( "Open in Gerrit")
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 222, Patchset 4 (Latest):
CHECK(json_value.has_value());Daniel Cheng . resolved
Should we have this `CHECK()` given the `value_or` below?
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 5, 2025, 4:31:27 AM (3 days ago) Sep 5
to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 5, 2025, 5:21:53 AM (3 days ago) Sep 5
to Lei Zhang, Daniel Cheng, chromium...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove deprecated base::JSONWriter::Write() calls in //services
Mechanically switch from base::JSONWriter::Write() to base::WriteJson().
Keep the existing behavior for all callers. So if a caller does not
check the Write() return result, then return an empty string on failure.
This CL was initially AI generated, with https://crrev.com/c/6916012 as
the human-written example CL to follow. With some human touch-ups.
Change-Id: I83eb012214f0213e9e32810fbd50c84ffe4e9b2f
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511400}
Files:
- M services/data_decoder/public/cpp/json_sanitizer_non_android.cc
- M services/device/geolocation/network_location_request.cc
- M services/image_annotation/annotator.cc
- M services/image_annotation/annotator_unittest.cc
- M services/network/sct_auditing/sct_auditing_handler.cc
- M services/network/trust_tokens/trust_token_key_commitment_parser_unittest.cc
- M services/tracing/public/cpp/perfetto/metadata_data_source.cc
- M services/tracing/public/cpp/perfetto/trace_event_metadata_source.cc
Change size: S
Delta: 8 files changed, 13 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages