[fenced frames] Remove sharedStorage.get() in fenced frames [chromium/src : main]

0 views
Skip to first unread message

Maks Orlovich (Gerrit)

unread,
Apr 1, 2026, 4:02:26 PM (3 days ago) Apr 1
to Shivani Sharma, Fiona Macintosh, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Fiona Macintosh, Mike West and Shivani Sharma

Maks Orlovich voted and added 1 comment

Votes added by Maks Orlovich

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 23 (Latest):
Maks Orlovich . resolved

services/network LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
  • Mike West
  • Shivani Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
Gerrit-Change-Number: 7709973
Gerrit-PatchSet: 23
Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shivani Sharma (Gerrit)

unread,
Apr 1, 2026, 4:21:11 PM (3 days ago) Apr 1
to Mike Taylor, Maks Orlovich, Fiona Macintosh, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Fiona Macintosh, Mike Taylor and Mike West

Shivani Sharma added 1 comment

Patchset-level comments
Shivani Sharma . resolved

miketaylr@, PTAL at third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
  • Mike Taylor
  • Mike West
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
Gerrit-Change-Number: 7709973
Gerrit-PatchSet: 23
Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
Gerrit-Attention: Mike Taylor <mike...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike Taylor (Gerrit)

unread,
Apr 1, 2026, 4:24:49 PM (3 days ago) Apr 1
to Shivani Sharma, Maks Orlovich, Fiona Macintosh, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Fiona Macintosh, Mike West and Shivani Sharma

Mike Taylor voted and added 1 comment

Votes added by Mike Taylor

Code-Review+1

1 comment

Patchset-level comments
Mike Taylor . resolved

global-interface-listing-expected.txt LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
  • Mike West
  • Shivani Sharma
Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:24:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shivani Sharma (Gerrit)

unread,
Apr 1, 2026, 4:25:49 PM (3 days ago) Apr 1
to Xiaochen Zhou, Mike Taylor, Maks Orlovich, Fiona Macintosh, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Fiona Macintosh, Mike West, Shivani Sharma and Xiaochen Zhou

Shivani Sharma added 1 comment

Patchset-level comments
Shivani Sharma . resolved

xiaochenzh@, PTAL at tools/metrics/histograms/metadata/privacy/histograms.xml, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
  • Mike West
  • Shivani Sharma
  • Xiaochen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
Gerrit-Change-Number: 7709973
Gerrit-PatchSet: 23
Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
Gerrit-Attention: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Shivani Sharma (Gerrit)

unread,
Apr 1, 2026, 4:31:49 PM (3 days ago) Apr 1
to Ian Clelland, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Fiona Macintosh, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Fiona Macintosh, Ian Clelland, Mike West and Xiaochen Zhou

Shivani Sharma added 1 comment

Patchset-level comments
Shivani Sharma . resolved

iclelland@, PTAL at tools/metrics/histograms/metadata/blink/histograms.xml, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
  • Ian Clelland
  • Mike West
  • Xiaochen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
Gerrit-Change-Number: 7709973
Gerrit-PatchSet: 23
Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Ian Clelland <icle...@chromium.org>
Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
Gerrit-Attention: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:31:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Xiaochen Zhou (Gerrit)

unread,
Apr 1, 2026, 4:32:53 PM (3 days ago) Apr 1
to Shivani Sharma, Ian Clelland, Mike Taylor, Maks Orlovich, Fiona Macintosh, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Fiona Macintosh, Ian Clelland, Mike West and Shivani Sharma

Xiaochen Zhou voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
  • Ian Clelland
  • Mike West
  • Shivani Sharma
Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Ian Clelland <icle...@chromium.org>
Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:32:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Apr 1, 2026, 4:53:31 PM (3 days ago) Apr 1
to Shivani Sharma, Xiaochen Zhou, Ian Clelland, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Ian Clelland, Mike West and Shivani Sharma

Fiona Macintosh voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:53:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Clelland (Gerrit)

unread,
Apr 1, 2026, 4:55:10 PM (3 days ago) Apr 1
to Shivani Sharma, Fiona Macintosh, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Mike West and Shivani Sharma

Ian Clelland voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
  • Shivani Sharma
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:54:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shivani Sharma (Gerrit)

unread,
Apr 1, 2026, 5:01:00 PM (3 days ago) Apr 1
to Andrey Kosyakov, Ian Clelland, Fiona Macintosh, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Andrey Kosyakov and Mike West

Shivani Sharma added 1 comment

Patchset-level comments
Shivani Sharma . resolved

caseq@, PTAL at headless/lib/browser/headless_content_browser_client*, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Mike West
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
Gerrit-Change-Number: 7709973
Gerrit-PatchSet: 23
Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 21:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Apr 1, 2026, 5:15:07 PM (3 days ago) Apr 1
to Shivani Sharma, Ian Clelland, Fiona Macintosh, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Mike West and Shivani Sharma

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review+1

1 comment

Patchset-level comments
Andrey Kosyakov . resolved

headless/ rslgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
  • Shivani Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 21:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shivani Sharma (Gerrit)

unread,
Apr 2, 2026, 11:18:15 AM (2 days ago) Apr 2
to Andrey Kosyakov, Ian Clelland, Fiona Macintosh, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
Attention needed from Mike West

Shivani Sharma added 1 comment

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
Line 9138, Patchset 17 (Parent): method get
Mike West . resolved

Blink side of this LGTM, but you'll need an API owner to weigh in on this. I assume you sent an intent already?

Andrew Verge

Allowing sharedStorage.get() from documents (fenced frames) never actually shipped; we only got as far as I2P. Do we still need an intent to remove it?

Shivani Sharma

+1. shared storage.get() is gated behind a default disabled feature flag and it was never enabled.

flag: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/common/features.cc;drc=f79a5eea7a342c492253d84aa68d44513fa84ef4;l=750

gate:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/shared_storage/shared_storage.cc;drc=f79a5eea7a342c492253d84aa68d44513fa84ef4;l=765

Shivani Sharma

Resolving based on above and miketaylr@'s lgtm.

Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Mike West <mk...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 15:17:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Shivani Sharma <shiva...@chromium.org>
    Comment-In-Reply-To: Andrew Verge <ave...@chromium.org>
    Comment-In-Reply-To: Mike West <mk...@chromium.org>
    satisfied_requirement
    open
    diffy

    Shivani Sharma (Gerrit)

    unread,
    Apr 2, 2026, 11:18:36 AM (2 days ago) Apr 2
    to Andrey Kosyakov, Ian Clelland, Fiona Macintosh, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Chromium LUCI CQ, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org
    Attention needed from Mike West

    Shivani Sharma voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Thu, 02 Apr 2026 15:18:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 2, 2026, 11:23:53 AM (2 days ago) Apr 2
    to Shivani Sharma, Andrey Kosyakov, Ian Clelland, Fiona Macintosh, Xiaochen Zhou, Mike Taylor, Maks Orlovich, Alex Moshchuk, Andrew Verge, Mike West, Yao Xiao, Peter Beverloo, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org, headless...@chromium.org, devtools...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, storage...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [fenced frames] Remove sharedStorage.get() in fenced frames

    This is the 1st CL in a series that removes fenced storage read(FSR)
    code. This CL does the following:
    - removes sharedStorage.get() from a FF
    - removes the related permission policy
    - removes the related attestation category and checks

    Follow up CLs will remove disableUntrustedNetwork and fence.notifyEvent
    APIs introduced for FSR.

    Fenced Storage Read's "do not launch" status announcement:
    https://privacysandbox.google.com/overview/status

    sharedStorage.get() in FFs is gated behind a default disabled feature
    flag and it was never enabled, so this CL does not impact any launched behavior.
    Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
    Commit-Queue: Shivani Sharma <shiva...@chromium.org>
    Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
    Reviewed-by: Mike West <mk...@chromium.org>
    Reviewed-by: Alex Moshchuk <ale...@chromium.org>
    Reviewed-by: Fiona Macintosh <fmaci...@google.com>
    Reviewed-by: Xiaochen Zhou <xiaoc...@chromium.org>
    Reviewed-by: Mike Taylor <mike...@chromium.org>
    Reviewed-by: Maks Orlovich <morl...@chromium.org>
    Reviewed-by: Yao Xiao <yao...@chromium.org>
    Reviewed-by: Ian Clelland <icle...@chromium.org>
    Reviewed-by: Andrew Verge <ave...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1609227}
    Files:
    • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
    • M chrome/browser/chrome_content_browser_client.cc
    • M chrome/browser/chrome_content_browser_client.h
    • M chrome/browser/storage/shared_storage_browsertest.cc
    • M components/privacy_sandbox/mock_privacy_sandbox_settings.h
    • M components/privacy_sandbox/privacy_sandbox_attestations/privacy_sandbox_attestations_parser.cc
    • M components/privacy_sandbox/privacy_sandbox_attestations/privacy_sandbox_attestations_parser_unittest.cc
    • M components/privacy_sandbox/privacy_sandbox_attestations/proto/privacy_sandbox_attestations.proto
    • M components/privacy_sandbox/privacy_sandbox_settings.h
    • M components/privacy_sandbox/privacy_sandbox_settings_impl.cc
    • M components/privacy_sandbox/privacy_sandbox_settings_impl.h
    • M components/privacy_sandbox/privacy_sandbox_settings_impl_unittest.cc
    • M components/privacy_sandbox/privacy_sandbox_test_util.cc
    • M components/privacy_sandbox/privacy_sandbox_test_util.h
    • M content/browser/fenced_frame/fenced_frame_browsertest.cc
    • M content/browser/private_aggregation/private_aggregation_test_utils.h
    • M content/browser/renderer_host/render_frame_host_impl.cc
    • M content/browser/renderer_host/render_frame_host_impl.h
    • M content/browser/shared_storage/shared_storage_document_service_impl.cc
    • M content/browser/shared_storage/shared_storage_document_service_impl.h
    • M content/browser/shared_storage/shared_storage_fenced_frame_browsertest.cc
    • M content/public/browser/content_browser_client.cc
    • M content/public/browser/content_browser_client.h
    • M content/public/test/shared_storage_test_utils.cc
    • M content/public/test/shared_storage_test_utils.h
    • M content/shell/browser/shell_content_browser_client.cc
    • M content/shell/browser/shell_content_browser_client.h
    • M headless/lib/browser/headless_content_browser_client.cc
    • M headless/lib/browser/headless_content_browser_client.h
    • M services/network/public/cpp/permissions_policy/fenced_frame_permissions_policies.h
    • M services/network/public/cpp/permissions_policy/permissions_policy_features.json5
    • M services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom
    • M third_party/blink/common/fenced_frame/fenced_frame_utils.cc
    • M third_party/blink/public/common/fenced_frame/fenced_frame_utils.h
    • M third_party/blink/public/devtools_protocol/domains/Page.pdl
    • M third_party/blink/public/mojom/shared_storage/shared_storage.mojom
    • M third_party/blink/public/mojom/shared_storage/shared_storage_worklet_service.mojom
    • M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
    • M third_party/blink/renderer/modules/shared_storage/shared_storage.cc
    • M third_party/blink/renderer/modules/shared_storage/shared_storage.idl
    • D third_party/blink/web_tests/http/tests/inspector-protocol/shared-storage/resources/deprecation-get.https.html
    • M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
    • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/content-shared-storage-get-nested.https.html
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/content-shared-storage-get.https.html
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/resources/unpartitioned_storage_permissions_policy_helper.js
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-allow.tentative.https.sub.html
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-none.tentative.https.sub.html
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-none.tentative.https.sub.html.headers
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-self.tentative.https.sub.html
    • D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-self.tentative.https.sub.html.headers
    • M tools/metrics/histograms/metadata/blink/enums.xml
    • M tools/metrics/histograms/metadata/blink/histograms.xml
    • M tools/metrics/histograms/metadata/privacy/histograms.xml
    Change size: XL
    Delta: 54 files changed, 57 insertions(+), 1970 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Maks Orlovich, +1 by Mike Taylor, +1 by Andrey Kosyakov, +1 by Ian Clelland, +1 by Yao Xiao, +1 by Alex Moshchuk, +1 by Xiaochen Zhou, +1 by Fiona Macintosh, +1 by Mike West, +1 by Andrew Verge
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15
    Gerrit-Change-Number: 7709973
    Gerrit-PatchSet: 24
    Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
    Gerrit-Reviewer: Xiaochen Zhou <xiaoc...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages