RestrictedUDPSocket: Add private network check to SendTo [chromium/src : main]

0 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Feb 26, 2026, 8:31:06 AM (5 days ago) Feb 26
to Tianyi Hu, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, fenced-fra...@chromium.org, network-ser...@chromium.org
Attention needed from Tianyi Hu

Andrew Rayskiy voted and added 1 comment

Votes added by Andrew Rayskiy

Code-Review-1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andrew Rayskiy . unresolved

SendTo() is only available to UDPSocket in bound mode (that requires prior permission from DIRECT_SOCKETS_PRIVATE_NETWORK_ACCESS content setting). There's work underway to migrate it to LOCAL_NETWORK_ACCESS in CL 4569839.

Open in Gerrit

Related details

Attention is currently required from:
  • Tianyi Hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is blockingCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467a30fb5f0d16224b98fc35862f7fbc71fba3d9
Gerrit-Change-Number: 7610429
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Hu <oscar...@gmail.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Tianyi Hu <oscar...@gmail.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Tianyi Hu <oscar...@gmail.com>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:30:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
blocking_requirement
open
diffy

Andrew Rayskiy (Gerrit)

unread,
Feb 26, 2026, 8:32:02 AM (5 days ago) Feb 26
to Tianyi Hu, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, fenced-fra...@chromium.org, network-ser...@chromium.org
Attention needed from Tianyi Hu

Andrew Rayskiy added 1 comment

Patchset-level comments
Andrew Rayskiy . unresolved

SendTo() is only available to UDPSocket in bound mode (that requires prior permission from DIRECT_SOCKETS_PRIVATE_NETWORK_ACCESS content setting). There's work underway to migrate it to LOCAL_NETWORK_ACCESS in CL 4569839.

Andrew Rayskiy

(-1 since this might break our current flows -- we need to organize a more structured migration from DIRECT_SOCKETS_PRIVATE_NETWORK_ACCESS to LOCAL_NETWORK_ACCESS).

Gerrit-Comment-Date: Thu, 26 Feb 2026 13:31:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>
satisfied_requirement
unsatisfied_requirement
blocking_requirement
open
diffy

Tianyi Hu (Gerrit)

unread,
Feb 27, 2026, 8:44:34 AM (4 days ago) Feb 27
to Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, fenced-fra...@chromium.org, network-ser...@chromium.org
Attention needed from Andrew Rayskiy

Tianyi Hu added 1 comment

Patchset-level comments
Andrew Rayskiy . unresolved

SendTo() is only available to UDPSocket in bound mode (that requires prior permission from DIRECT_SOCKETS_PRIVATE_NETWORK_ACCESS content setting). There's work underway to migrate it to LOCAL_NETWORK_ACCESS in CL 4569839.

Andrew Rayskiy

(-1 since this might break our current flows -- we need to organize a more structured migration from DIRECT_SOCKETS_PRIVATE_NETWORK_ACCESS to LOCAL_NETWORK_ACCESS).

Tianyi Hu

You're right — bound mode already gates on DIRECT_SOCKETS_PRIVATE_NETWORK_ACCESS at socket creation. Abandoning this CL.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is blockingCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467a30fb5f0d16224b98fc35862f7fbc71fba3d9
Gerrit-Change-Number: 7610429
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Hu <oscar...@gmail.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Tianyi Hu <oscar...@gmail.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Andrew Rayskiy <green...@google.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 13:44:03 +0000
satisfied_requirement
unsatisfied_requirement
blocking_requirement
open
diffy

Tianyi Hu (Gerrit)

unread,
Feb 27, 2026, 8:44:40 AM (4 days ago) Feb 27
to Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, fenced-fra...@chromium.org, network-ser...@chromium.org

Tianyi Hu abandoned this change.

View Change

Abandoned

Tianyi Hu abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is blockingCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
blocking_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages