Issue 1490052 in chromium: Flag expired : network-service-in-process is expired in M120

10 views
Skip to first unread message

chrome-branch-day via monorail

unread,
Oct 5, 2023, 3:48:53 PM10/5/23
to network-s...@chromium.org

Comment #1 on issue 1490052 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : network-service-in-process is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490052#c1

This flag has been marked as expiring in M120 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M120 branch you're all set; if you do it after the M120 branch you'll need to merge that CL to the M120 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

dom via monorail

unread,
Oct 10, 2023, 10:39:10 AM10/10/23
to network-s...@chromium.org
Updates:
Cc: d...@chromium.org
Components: Internals>Services>Network
Status: Untriaged

Comment #2 on issue 1490052 by d...@chromium.org: Flag expired : network-service-in-process is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490052#c2

Marking this as untriaged and moving to the Network Service so an owner there can get notified and take proper action.

sisidovski via monorail

unread,
Oct 13, 2023, 2:10:24 AM10/13/23
to network-s...@chromium.org
Updates:
Cc: kou...@chromium.org
Status: Available

Comment #3 on issue 1490052 by sisid...@chromium.org: Flag expired : network-service-in-process is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490052#c3

[Loading Bug Triage]
Make the status Available. It looks originally the flag was added by yhirano, who is not working on it anymore.
Can someone in the networking team take this?

ricea via monorail

unread,
Oct 13, 2023, 6:08:48 AM10/13/23
to network-s...@chromium.org
Updates:
Owner: yoi...@chromium.org
Status: Assigned

Comment #4 on issue 1490052 by ri...@chromium.org: Flag expired : network-service-in-process is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490052#c4

Assigning to yoichio@ who has the most context.

yoichio via monorail

unread,
Oct 15, 2023, 9:46:32 PM10/15/23
to network-s...@chromium.org
Updates:
Blocking: 1487447

Comment #5 on issue 1490052 by yoi...@chromium.org: Flag expired : network-service-in-process is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490052#c5

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Oct 16, 2023, 12:45:15 AM10/16/23
to network-s...@chromium.org
Updates:
Status: Fixed

Comment #6 on issue 1490052 by Git Watcher: Flag expired : network-service-in-process is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490052#c6

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/f6d0a39be671a72bc8296b4fb7b883dace4b4f31

commit f6d0a39be671a72bc8296b4fb7b883dace4b4f31
Author: Yoichi Osato <yoi...@chromium.org>
Date: Mon Oct 16 04:44:12 2023

Remove kNetworkServiceInProcessName flag from chrome://flags UI.

The flag was introduced at
commit I9ab3eee736021a27918938d9a42d3b6782666cef

This CL also cleans up the leftover in
Id55d8798923b57c724906d4da75d9ca8aa34f059

Fixed: 1490052
Change-Id: I651a1224a2d4ced06d12b28485e1598a095d6297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4938254
Commit-Queue: Yoichi Osato <yoi...@chromium.org>
Auto-Submit: Yoichi Osato <yoi...@chromium.org>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210001}

[modify] https://crrev.com/f6d0a39be671a72bc8296b4fb7b883dace4b4f31/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f6d0a39be671a72bc8296b4fb7b883dace4b4f31/chrome/browser/about_flags.cc
[modify] https://crrev.com/f6d0a39be671a72bc8296b4fb7b883dace4b4f31/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f6d0a39be671a72bc8296b4fb7b883dace4b4f31/chrome/browser/flag-metadata.json
Reply all
Reply to author
Forward
0 new messages