Issue 1489806 in chromium: Flag expired : broker-file-operations-on-disk-cache-in-network-service is expired in M120

24 views
Skip to first unread message

chrome-branch-day via monorail

unread,
Oct 5, 2023, 3:36:52 PM10/5/23
to network-s...@chromium.org

Comment #1 on issue 1489806 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : broker-file-operations-on-disk-cache-in-network-service is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489806#c1

This flag has been marked as expiring in M120 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M120 branch you're all set; if you do it after the M120 branch you'll need to merge that CL to the M120 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

dom via monorail

unread,
Oct 10, 2023, 10:41:01 AM10/10/23
to network-s...@chromium.org
Updates:
Cc: d...@chromium.org
Components: Internals>Services>Network
Status: Untriaged

Comment #2 on issue 1489806 by d...@chromium.org: Flag expired : broker-file-operations-on-disk-cache-in-network-service is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489806#c2

Marking as untriaged and moving to Network Service component so this will get a triager's attn.

horo via monorail

unread,
Oct 10, 2023, 8:02:35 PM10/10/23
to network-s...@chromium.org
Updates:
Owner: yoi...@chromium.org
Status: Assigned

Comment #3 on issue 1489806 by ho...@chromium.org: Flag expired : broker-file-operations-on-disk-cache-in-network-service is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489806#c3

yoichio@
Is this in your scope of removing Android network sandbox related code?

yoichio via monorail

unread,
Oct 10, 2023, 8:08:14 PM10/10/23
to network-s...@chromium.org
Updates:
Blocking: 1487447

Comment #4 on issue 1489806 by yoi...@chromium.org: Flag expired : broker-file-operations-on-disk-cache-in-network-service is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489806#c4

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Oct 12, 2023, 12:21:13 AM10/12/23
to network-s...@chromium.org
Updates:
Status: Fixed

Comment #5 on issue 1489806 by Git Watcher: Flag expired : broker-file-operations-on-disk-cache-in-network-service is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489806#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/7ccaaaebb50bd741aac019fb09151c64c7fd410a

commit 7ccaaaebb50bd741aac019fb09151c64c7fd410a
Author: Yoichi Osato <yoi...@chromium.org>
Date: Thu Oct 12 04:20:31 2023

Remove kBrokerFileOperationsOnDiskCacheInNetworkService flag from chrome://flags UI.

The flag was introduced at
commit I183ec326d63b06234f5c35ae0239856d331507c1

Fixed: 1489806
Change-Id: Id55d8798923b57c724906d4da75d9ca8aa34f059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4930462
Commit-Queue: Yoichi Osato <yoi...@chromium.org>
Commit-Queue: Tsuyoshi Horo <ho...@chromium.org>
Auto-Submit: Yoichi Osato <yoi...@chromium.org>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1208653}

[modify] https://crrev.com/7ccaaaebb50bd741aac019fb09151c64c7fd410a/chrome/browser/about_flags.cc
[modify] https://crrev.com/7ccaaaebb50bd741aac019fb09151c64c7fd410a/chrome/browser/flag-metadata.json
Reply all
Reply to author
Forward
0 new messages