Add LINT.IfChange checks for Java enums persisted to logs [chromium/src : main]

0 views
Skip to first unread message

Theresa Sullivan (Gerrit)

unread,
Apr 2, 2026, 8:34:29 PM (3 days ago) Apr 2
to Gazal Agarwal, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Gazal Agarwal

Theresa Sullivan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Gazal Agarwal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87d0ab7a68a0ed4daef15bb0b03eaa67bccb8b2f
Gerrit-Change-Number: 7727003
Gerrit-PatchSet: 1
Gerrit-Owner: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Gazal Agarwal <aga...@google.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 00:34:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Evan Liu (Gerrit)

unread,
Apr 3, 2026, 2:17:40 AM (3 days ago) Apr 3
to Gazal Agarwal, Jinsuk Kim, Olivia Saul, Sinan Sahin, Guillem Perez, Shakti Sahu, Max Curran, Michael Thiessen, Justin Donnelly, Darryl James, Abe Boujane, Tomasz Wiszkowski, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Abe Boujane, Darryl James, Darwin Yang, Gazal Agarwal, Guillem Perez, Jinsuk Kim, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul, Shakti Sahu, Sinan Sahin and Tomasz Wiszkowski

Evan Liu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Abe Boujane
  • Darryl James
  • Darwin Yang
  • Gazal Agarwal
  • Guillem Perez
  • Jinsuk Kim
  • Justin Donnelly
  • Max Curran
  • Michael Thiessen
  • Olivia Saul
  • Shakti Sahu
  • Sinan Sahin
  • Tomasz Wiszkowski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87d0ab7a68a0ed4daef15bb0b03eaa67bccb8b2f
Gerrit-Change-Number: 7727003
Gerrit-PatchSet: 1
Gerrit-Owner: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Abe Boujane <bou...@google.com>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Darwin Yang <darwi...@chromium.org>
Gerrit-Reviewer: Evan Liu <ev...@google.com>
Gerrit-Reviewer: Gazal Agarwal <aga...@google.com>
Gerrit-Reviewer: Guillem Perez <guip...@google.com>
Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-Reviewer: Max Curran <curr...@chromium.org>
Gerrit-Reviewer: Michael Thiessen <mthi...@chromium.org>
Gerrit-Reviewer: Olivia Saul <os...@google.com>
Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
Gerrit-Reviewer: Sinan Sahin <sinan...@google.com>
Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Guillem Perez <guip...@google.com>
Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
Gerrit-Attention: Gazal Agarwal <aga...@google.com>
Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
Gerrit-Attention: Abe Boujane <bou...@google.com>
Gerrit-Attention: Olivia Saul <os...@google.com>
Gerrit-Attention: Max Curran <curr...@chromium.org>
Gerrit-Attention: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Shakti Sahu <shakt...@chromium.org>
Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 06:17:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinsuk Kim (Gerrit)

unread,
Apr 3, 2026, 6:55:09 AM (3 days ago) Apr 3
to Gazal Agarwal, Evan Liu, Olivia Saul, Sinan Sahin, Guillem Perez, Shakti Sahu, Max Curran, Michael Thiessen, Justin Donnelly, Darryl James, Abe Boujane, Tomasz Wiszkowski, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Abe Boujane, Darryl James, Darwin Yang, Gazal Agarwal, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul, Shakti Sahu, Sinan Sahin and Tomasz Wiszkowski

Jinsuk Kim voted and added 1 comment

Votes added by Jinsuk Kim

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jinsuk Kim . resolved

CustomTabs lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Abe Boujane
  • Darryl James
  • Darwin Yang
  • Gazal Agarwal
  • Guillem Perez
Gerrit-Attention: Sinan Sahin <sinan...@google.com>
Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
Gerrit-Attention: Shakti Sahu <shakt...@chromium.org>
Gerrit-Attention: Gazal Agarwal <aga...@google.com>
Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
Gerrit-Attention: Abe Boujane <bou...@google.com>
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Attention: Olivia Saul <os...@google.com>
Gerrit-Attention: Max Curran <curr...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 10:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Darryl James (Gerrit)

unread,
Apr 3, 2026, 2:24:52 PM (2 days ago) Apr 3
to Gazal Agarwal, Jinsuk Kim, Evan Liu, Olivia Saul, Sinan Sahin, Guillem Perez, Shakti Sahu, Max Curran, Michael Thiessen, Justin Donnelly, Abe Boujane, Tomasz Wiszkowski, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Abe Boujane, Darwin Yang, Gazal Agarwal, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul, Shakti Sahu, Sinan Sahin and Tomasz Wiszkowski

Darryl James voted and added 2 comments

Votes added by Darryl James

Code-Review+1

2 comments

Patchset-level comments
Darryl James . resolved

lgtm for tab/enums.xml; thanks for the cleanup!

File chrome/android/java/src/org/chromium/chrome/browser/tab/tab_restore/HistoricalTabSaverImpl.java
Line 51, Patchset 1 (Latest): int COUNT = 3;
Darryl James . unresolved

Speaking of keeping things in sync, it looks like this one is missed from the associated enum file!

Would you be willing to update that in this CL while you are in the area?

Open in Gerrit

Related details

Attention is currently required from:
  • Abe Boujane
  • Darwin Yang
  • Gazal Agarwal
  • Guillem Perez
  • Justin Donnelly
  • Max Curran
  • Michael Thiessen
  • Olivia Saul
  • Shakti Sahu
  • Sinan Sahin
  • Tomasz Wiszkowski
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Gerrit-Attention: Olivia Saul <os...@google.com>
      Gerrit-Attention: Max Curran <curr...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Apr 2026 18:24:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Gazal Agarwal (Gerrit)

      unread,
      Apr 3, 2026, 3:18:38 PM (2 days ago) Apr 3
      to Darryl James, Jinsuk Kim, Evan Liu, Olivia Saul, Sinan Sahin, Guillem Perez, Shakti Sahu, Max Curran, Michael Thiessen, Justin Donnelly, Abe Boujane, Tomasz Wiszkowski, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
      Attention needed from Abe Boujane, Darwin Yang, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul, Shakti Sahu, Sinan Sahin and Tomasz Wiszkowski

      Gazal Agarwal added 2 comments

      File chrome/android/java/src/org/chromium/chrome/browser/tab/tab_restore/HistoricalTabSaverImpl.java
      Darryl James . unresolved

      Speaking of keeping things in sync, it looks like this one is missed from the associated enum file!

      Would you be willing to update that in this CL while you are in the area?

      Gazal Agarwal

      Thanks for pointing out. I do see usages of `COUNT` in recording histograms within the Impl. Looks like the `enum` was added before we started recording metrics. So

      Darryl James . resolved

      Speaking of keeping things in sync, it looks like this one is missed from the associated enum file!

      Would you be willing to update that in this CL while you are in the area?

      Gazal Agarwal

      Thanks for checking!

      The missing value here is `COUNT = 3`. In Chromium, sentinel values like COUNT = 3 are intentionally omitted from enums.xml. While COUNT is passed to the RecordHistogram methods to define the histogram's boundary (bucket size), it is never actually recorded as a data point. Including it in the XML would create a 'ghost' category on our dashboards that always shows zero hits. The LINT.IfChange tags are used here as a logical synchronization tool to ensure that if we add a new functional type (like WINDOW = 3), we remember to update the mapping in both files!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Abe Boujane
      • Darwin Yang
      Gerrit-Attention: Tomasz Wiszkowski <en...@google.com>
      Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
      Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
      Gerrit-Attention: Abe Boujane <bou...@google.com>
      Gerrit-Attention: Olivia Saul <os...@google.com>
      Gerrit-Attention: Max Curran <curr...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Apr 2026 19:18:17 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Darryl James <dlj...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Gazal Agarwal (Gerrit)

      unread,
      Apr 3, 2026, 3:19:33 PM (2 days ago) Apr 3
      to Darryl James, Jinsuk Kim, Evan Liu, Olivia Saul, Sinan Sahin, Guillem Perez, Shakti Sahu, Max Curran, Michael Thiessen, Justin Donnelly, Abe Boujane, Tomasz Wiszkowski, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
      Attention needed from Abe Boujane, Darwin Yang, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul, Shakti Sahu, Sinan Sahin and Tomasz Wiszkowski

      Gazal Agarwal added 1 comment

      File chrome/android/java/src/org/chromium/chrome/browser/tab/tab_restore/HistoricalTabSaverImpl.java
      Darryl James . resolved

      Speaking of keeping things in sync, it looks like this one is missed from the associated enum file!

      Would you be willing to update that in this CL while you are in the area?

      Gazal Agarwal

      Thanks for pointing out. I do see usages of `COUNT` in recording histograms within the Impl. Looks like the `enum` was added before we started recording metrics. So

      Gazal Agarwal

      Please ignore the last (third) comment!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Abe Boujane
      • Darwin Yang
      • Guillem Perez
      • Justin Donnelly
      • Max Curran
      • Michael Thiessen
      • Olivia Saul
      • Shakti Sahu
      • Sinan Sahin
      • Tomasz Wiszkowski
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Gerrit-Comment-Date: Fri, 03 Apr 2026 19:19:21 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Gazal Agarwal <aga...@google.com>
        Comment-In-Reply-To: Darryl James <dlj...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Tomasz Wiszkowski (Gerrit)

        unread,
        Apr 3, 2026, 4:56:55 PM (2 days ago) Apr 3
        to Gazal Agarwal, Darryl James, Jinsuk Kim, Evan Liu, Olivia Saul, Sinan Sahin, Guillem Perez, Shakti Sahu, Max Curran, Michael Thiessen, Justin Donnelly, Abe Boujane, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
        Attention needed from Abe Boujane, Darwin Yang, Gazal Agarwal, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul, Shakti Sahu and Sinan Sahin

        Tomasz Wiszkowski voted and added 1 comment

        Votes added by Tomasz Wiszkowski

        Code-Review+1

        1 comment

        Patchset-level comments
        Tomasz Wiszkowski . resolved

        search enums lgtm.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Abe Boujane
        • Darwin Yang
        • Gazal Agarwal
        • Guillem Perez
        • Justin Donnelly
        • Max Curran
        • Michael Thiessen
        • Olivia Saul
        • Shakti Sahu
        • Sinan Sahin
        Gerrit-Attention: Gazal Agarwal <aga...@google.com>
        Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
        Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
        Gerrit-Attention: Abe Boujane <bou...@google.com>
        Gerrit-Attention: Olivia Saul <os...@google.com>
        Gerrit-Attention: Max Curran <curr...@chromium.org>
        Gerrit-Comment-Date: Fri, 03 Apr 2026 20:56:40 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Shakti Sahu (Gerrit)

        unread,
        Apr 3, 2026, 5:24:52 PM (2 days ago) Apr 3
        to Gazal Agarwal, Tomasz Wiszkowski, Darryl James, Jinsuk Kim, Evan Liu, Olivia Saul, Sinan Sahin, Guillem Perez, Max Curran, Michael Thiessen, Justin Donnelly, Abe Boujane, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
        Attention needed from Abe Boujane, Darwin Yang, Gazal Agarwal, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen, Olivia Saul and Sinan Sahin

        Shakti Sahu voted and added 1 comment

        Votes added by Shakti Sahu

        Code-Review+1

        1 comment

        Patchset-level comments
        Shakti Sahu . resolved

        tools/metrics/histograms/metadata/download/enums.xml lgtm

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Abe Boujane
        • Darwin Yang
        • Gazal Agarwal
        • Guillem Perez
        • Justin Donnelly
        • Max Curran
        • Michael Thiessen
        • Olivia Saul
        • Sinan Sahin
        Gerrit-Attention: Gazal Agarwal <aga...@google.com>
        Gerrit-Attention: Michael Thiessen <mthi...@chromium.org>
        Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
        Gerrit-Attention: Abe Boujane <bou...@google.com>
        Gerrit-Attention: Olivia Saul <os...@google.com>
        Gerrit-Attention: Max Curran <curr...@chromium.org>
        Gerrit-Comment-Date: Fri, 03 Apr 2026 21:24:39 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Olivia Saul (Gerrit)

        unread,
        Apr 3, 2026, 5:51:33 PM (2 days ago) Apr 3
        to Gazal Agarwal, Olivia Saul, Shakti Sahu, Tomasz Wiszkowski, Darryl James, Jinsuk Kim, Evan Liu, Sinan Sahin, Guillem Perez, Max Curran, Michael Thiessen, Justin Donnelly, Abe Boujane, Darwin Yang, Theresa Sullivan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, chromiumme...@microsoft.com, davidj...@chromium.org, donnd...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, gangwu...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, sloboda...@chromium.org, twelling...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
        Attention needed from Abe Boujane, Darwin Yang, Gazal Agarwal, Guillem Perez, Justin Donnelly, Max Curran, Michael Thiessen and Sinan Sahin

        Olivia Saul voted and added 1 comment

        Votes added by Olivia Saul

        Code-Review+1
        Commit-Queue+2

        1 comment

        Patchset-level comments
        Olivia Saul . resolved

        Approved for autofill/enums.xml and the 5 code files associated with it. Thanks!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Abe Boujane
        • Darwin Yang
        • Gazal Agarwal
        • Guillem Perez
        • Justin Donnelly
        • Max Curran
        • Michael Thiessen
        • Sinan Sahin
        Gerrit-Attention: Max Curran <curr...@chromium.org>
        Gerrit-Comment-Date: Fri, 03 Apr 2026 21:51:17 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages