Record NetworkLoaderCompletionTime2 UMA per request priority [chromium/src : main]

0 views
Skip to first unread message

Hayato Ito (Gerrit)

unread,
Aug 14, 2025, 5:28:03 AMAug 14
to Takashi Toyoshima, Kenichi Ishibashi, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi and Takashi Toyoshima

Hayato Ito voted and added 1 comment

Votes added by Hayato Ito

Commit-Queue+1

1 comment

File net/base/request_priority.cc
Open in Gerrit

Related details

Attention is currently required from:
  • Kenichi Ishibashi
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
Gerrit-Change-Number: 6839683
Gerrit-PatchSet: 6
Gerrit-Owner: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Thu, 14 Aug 2025 09:27:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
Aug 14, 2025, 7:20:25 PMAug 14
to Hayato Ito, Takashi Toyoshima, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org
Attention needed from Hayato Ito and Takashi Toyoshima

Kenichi Ishibashi voted and added 1 comment

Votes added by Kenichi Ishibashi

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Kenichi Ishibashi . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Hayato Ito
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 6
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Hayato Ito <hay...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Thu, 14 Aug 2025 23:19:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    Aug 15, 2025, 2:24:42 AMAug 15
    to Hayato Ito, Kenichi Ishibashi, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org
    Attention needed from Hayato Ito

    Takashi Toyoshima voted and added 1 comment

    Votes added by Takashi Toyoshima

    Code-Review+1

    1 comment

    File net/base/request_priority.cc
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hayato Ito
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 6
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Hayato Ito <hay...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 Aug 2025 06:24:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Hayato Ito <hay...@chromium.org>
    Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hayato Ito (Gerrit)

    unread,
    Aug 15, 2025, 4:58:33 AMAug 15
    to Takashi Toyoshima, Kenichi Ishibashi, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org
    Attention needed from Kenichi Ishibashi and Takashi Toyoshima

    Hayato Ito voted and added 1 comment

    Votes added by Hayato Ito

    Commit-Queue+1

    1 comment

    File net/base/request_priority.cc
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenichi Ishibashi
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 9
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 Aug 2025 08:58:00 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kenichi Ishibashi (Gerrit)

    unread,
    Aug 17, 2025, 10:11:06 PMAug 17
    to Hayato Ito, Takashi Toyoshima, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org
    Attention needed from Hayato Ito and Takashi Toyoshima

    Kenichi Ishibashi voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hayato Ito
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 9
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Hayato Ito <hay...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 02:10:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    Aug 17, 2025, 11:49:25 PMAug 17
    to Hayato Ito, Kenichi Ishibashi, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org
    Attention needed from Hayato Ito

    Takashi Toyoshima voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hayato Ito
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 9
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Hayato Ito <hay...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 03:49:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hayato Ito (Gerrit)

    unread,
    Aug 17, 2025, 11:49:50 PMAug 17
    to Takashi Toyoshima, Kenichi Ishibashi, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org

    Hayato Ito voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 9
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Garcia Visiedo <vis...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 03:49:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 18, 2025, 12:48:49 AMAug 18
    to Hayato Ito, Takashi Toyoshima, Kenichi Ishibashi, Kentaro Hara, Javier Garcia Visiedo, Kouhei Ueno, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Record NetworkLoaderCompletionTime2 UMA per request priority

    This CL breaks down the `NetworkService.NetworkLoaderCompletionTime2`
    histogram by request priority. This allows for a more granular analysis
    of network performance characteristics for different priority levels.

    NO_IFTTT=Add Lint.IfChange
    Bug: 421051258
    Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
    Commit-Queue: Hayato Ito <hay...@chromium.org>
    Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1502530}
    Files:
    • M net/base/request_priority.cc
    • M services/network/cors/cors_url_loader.cc
    • M tools/metrics/histograms/metadata/network/histograms.xml
    Change size: M
    Delta: 3 files changed, 48 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kenichi Ishibashi, +1 by Takashi Toyoshima
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7feffedc887ab7ab1e26eee8ebd9560680a2bbf
    Gerrit-Change-Number: 6839683
    Gerrit-PatchSet: 10
    Gerrit-Owner: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages