Change HttpEngine's stem name to `libhttpengine` [chromium/src : main]

0 views
Skip to first unread message

Mohannad Farrag (Gerrit)

unread,
Dec 17, 2025, 9:59:05 AM (4 days ago) Dec 17
to chromium...@chromium.org, net-r...@chromium.org

Mohannad Farrag has uploaded the change for review

Commit message

Change HttpEngine's stem name to `libhttpengine`

Previously, HttpEngine shared library name was
`libmainlinecronet.{version}` which is fine. However, we want to remove
the version in order to collect afdo samples, and improve the
performance of the library by optimizing the hot code.
Bug: 469717475
Change-Id: Iaeffdaae5a3762e708a022d2fe9c7b52eb8d7658

Change diff

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java
index 0abebdf00..23fede4 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java
@@ -43,8 +43,9 @@
     private static boolean sInitialized;
 
     private static final String LIBRARY_NAME =
-            (BuildConfig.CRONET_FOR_AOSP_BUILD ? "mainlinecronet." : "cronet.")
-                    + ImplVersion.getCronetVersion();
+            (BuildConfig.CRONET_FOR_AOSP_BUILD
+                    ? "httpengine"
+                    : "cronet." + ImplVersion.getCronetVersion());
     private static final String TESTING_LIBRARY_NAME = LIBRARY_NAME + "_for_testing";
     private static boolean sSwitchToTestLibrary;
     @VisibleForTesting public static final String TAG = CronetLibraryLoader.class.getSimpleName();
diff --git a/components/cronet/gn2bp/gen_android_bp.py b/components/cronet/gn2bp/gen_android_bp.py
index a26ece8..e8b16f4 100755
--- a/components/cronet/gn2bp/gen_android_bp.py
+++ b/components/cronet/gn2bp/gen_android_bp.py
@@ -3082,7 +3082,7 @@
         # The AOSP version of CronetLibraryLoader looks for the libcronet so
         # with an extra suffix. Make sure the shared library name matches what
         # the loader expects.
-        module.stem = 'libmainline' + output_name
+        module.stem = 'libhttpengine'
       else:
         module.stem = 'lib' + output_name

Change information

Files:
  • M components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java
  • M components/cronet/gn2bp/gen_android_bp.py
Change size: XS
Delta: 2 files changed, 4 insertions(+), 3 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeffdaae5a3762e708a022d2fe9c7b52eb8d7658
Gerrit-Change-Number: 7268827
Gerrit-PatchSet: 1
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mohannad Farrag (Gerrit)

unread,
Dec 17, 2025, 9:59:12 AM (4 days ago) Dec 17
to Etienne Dechamps, Stefano Duo, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Dechamps and Stefano Duo

Mohannad Farrag voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Dechamps
  • Stefano Duo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeffdaae5a3762e708a022d2fe9c7b52eb8d7658
Gerrit-Change-Number: 7268827
Gerrit-PatchSet: 1
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Etienne Dechamps <edec...@google.com>
Gerrit-Comment-Date: Wed, 17 Dec 2025 14:58:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mohannad Farrag (Gerrit)

unread,
Dec 19, 2025, 9:06:35 AM (2 days ago) Dec 19
to Chromium LUCI CQ, Etienne Dechamps, Stefano Duo, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Dechamps and Stefano Duo

Mohannad Farrag voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Dechamps
  • Stefano Duo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeffdaae5a3762e708a022d2fe9c7b52eb8d7658
Gerrit-Change-Number: 7268827
Gerrit-PatchSet: 2
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Etienne Dechamps <edec...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 14:06:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mohannad Farrag (Gerrit)

unread,
Dec 19, 2025, 9:08:59 AM (2 days ago) Dec 19
to Chromium LUCI CQ, Etienne Dechamps, Stefano Duo, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Dechamps and Stefano Duo

Mohannad Farrag voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Dechamps
  • Stefano Duo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeffdaae5a3762e708a022d2fe9c7b52eb8d7658
Gerrit-Change-Number: 7268827
Gerrit-PatchSet: 3
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Etienne Dechamps <edec...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 14:08:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages