Add support for pre-warming BoringSSL self-tests in Cronet. [chromium/src : main]

0 views
Skip to first unread message

Mohannad Farrag (Gerrit)

unread,
Feb 20, 2026, 10:45:12 AM (21 hours ago) Feb 20
to AyeAye, droger+w...@chromium.org, net-r...@chromium.org

New activity on the change

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I814844fc9f69201eca1430e0d02f76ddd79bf53b
Gerrit-Change-Number: 7595725
Gerrit-PatchSet: 1
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 15:45:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mohannad Farrag (Gerrit)

unread,
Feb 20, 2026, 10:46:22 AM (21 hours ago) Feb 20
to Etienne Dechamps, AyeAye, droger+w...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Dechamps

Mohannad Farrag voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Dechamps
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I814844fc9f69201eca1430e0d02f76ddd79bf53b
Gerrit-Change-Number: 7595725
Gerrit-PatchSet: 2
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-Attention: Etienne Dechamps <edec...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 15:46:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sebastian Poreba (Gerrit)

unread,
Feb 20, 2026, 10:47:38 AM (21 hours ago) Feb 20
to Mohannad Farrag, Chromium LUCI CQ, Etienne Dechamps, AyeAye, droger+w...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Dechamps and Mohannad Farrag

Sebastian Poreba added 1 comment

File components/cronet/android/cronet_library_loader.cc
Line 164, Patchset 2 (Latest):static void JNI_CronetLibraryLoader_ExecuteSelfTests(JNIEnv* env) {
Sebastian Poreba . unresolved

Can you write a test that assures this doesn't explode?

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Dechamps
  • Mohannad Farrag
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I814844fc9f69201eca1430e0d02f76ddd79bf53b
    Gerrit-Change-Number: 7595725
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mohannad Farrag <aym...@google.com>
    Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
    Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
    Gerrit-Reviewer: Sebastian Poreba <spo...@google.com>
    Gerrit-Attention: Mohannad Farrag <aym...@google.com>
    Gerrit-Attention: Etienne Dechamps <edec...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 15:47:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mohannad Farrag (Gerrit)

    unread,
    Feb 20, 2026, 10:51:10 AM (21 hours ago) Feb 20
    to Sebastian Poreba, Chromium LUCI CQ, Etienne Dechamps, AyeAye, droger+w...@chromium.org, net-r...@chromium.org
    Attention needed from Etienne Dechamps and Sebastian Poreba

    Mohannad Farrag added 1 comment

    File components/cronet/android/cronet_library_loader.cc
    Line 164, Patchset 2 (Latest):static void JNI_CronetLibraryLoader_ExecuteSelfTests(JNIEnv* env) {
    Sebastian Poreba . resolved

    Can you write a test that assures this doesn't explode?

    Mohannad Farrag

    If it explodes, it'll crash zygote and fail presubmit.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Dechamps
    • Sebastian Poreba
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I814844fc9f69201eca1430e0d02f76ddd79bf53b
      Gerrit-Change-Number: 7595725
      Gerrit-PatchSet: 2
      Gerrit-Owner: Mohannad Farrag <aym...@google.com>
      Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
      Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
      Gerrit-Reviewer: Sebastian Poreba <spo...@google.com>
      Gerrit-Attention: Sebastian Poreba <spo...@google.com>
      Gerrit-Attention: Etienne Dechamps <edec...@google.com>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 15:50:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Sebastian Poreba <spo...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sebastian Poreba (Gerrit)

      unread,
      Feb 20, 2026, 10:53:53 AM (21 hours ago) Feb 20
      to Mohannad Farrag, Chromium LUCI CQ, Etienne Dechamps, AyeAye, droger+w...@chromium.org, net-r...@chromium.org
      Attention needed from Etienne Dechamps and Mohannad Farrag

      Sebastian Poreba added 1 comment

      File components/cronet/android/cronet_library_loader.cc
      Line 164, Patchset 2 (Latest):static void JNI_CronetLibraryLoader_ExecuteSelfTests(JNIEnv* env) {
      Sebastian Poreba . resolved

      Can you write a test that assures this doesn't explode?

      Mohannad Farrag

      If it explodes, it'll crash zygote and fail presubmit.

      Sebastian Poreba

      That's not a good way to test it - you'd have to wait for the import to Android to find out. This is a non-standard way to call these methods, and we should have a test in Chromium that makes sure it continues to work correctly.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Etienne Dechamps
      • Mohannad Farrag
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I814844fc9f69201eca1430e0d02f76ddd79bf53b
      Gerrit-Change-Number: 7595725
      Gerrit-PatchSet: 2
      Gerrit-Owner: Mohannad Farrag <aym...@google.com>
      Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
      Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
      Gerrit-Reviewer: Sebastian Poreba <spo...@google.com>
      Gerrit-Attention: Mohannad Farrag <aym...@google.com>
      Gerrit-Attention: Etienne Dechamps <edec...@google.com>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 15:53:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Sebastian Poreba <spo...@google.com>
      Comment-In-Reply-To: Mohannad Farrag <aym...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages