[M140] Fix owners file to include additional.certs; also remove old bot as we're on pod batch now. [chromium/src : refs/branch-heads/7339]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Oct 10, 2025, 12:02:36 PM (2 days ago) Oct 10
to Chrome Cherry Picker, Hubert Chao, AyeAye, net-r...@chromium.org

Message from Rubber Stamper

The change is not in the configured time window. Rubber Stamper is only allowed to review cherry-picks within 14 day(s). Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7339
Gerrit-Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
Gerrit-Change-Number: 7030407
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Hubert Chao <hc...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 16:02:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
Oct 10, 2025, 1:04:31 PM (2 days ago) Oct 10
to Chrome Cherry Picker, Hubert Chao, AyeAye, net-r...@chromium.org

David Benjamin voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7339
Gerrit-Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
Gerrit-Change-Number: 7030407
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-CC: Hubert Chao <hc...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 17:04:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
Oct 10, 2025, 1:19:37 PM (2 days ago) Oct 10
to Chrome Cherry Picker, Hubert Chao, Joe DeBlasio, Chromium LUCI CQ, AyeAye, net-r...@chromium.org
Attention needed from Joe DeBlasio

David Benjamin added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
David Benjamin . resolved

Apparently this requires two stamps. I'm not sure why but adding Joe.

Open in Gerrit

Related details

Attention is currently required from:
  • Joe DeBlasio
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7339
Gerrit-Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
Gerrit-Change-Number: 7030407
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Joe DeBlasio <jdeb...@chromium.org>
Gerrit-CC: Hubert Chao <hc...@chromium.org>
Gerrit-Attention: Joe DeBlasio <jdeb...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 17:19:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe DeBlasio (Gerrit)

unread,
Oct 10, 2025, 1:29:08 PM (2 days ago) Oct 10
to Chrome Cherry Picker, Hubert Chao, Chromium LUCI CQ, David Benjamin, AyeAye, net-r...@chromium.org

Joe DeBlasio voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7339
Gerrit-Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
Gerrit-Change-Number: 7030407
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Joe DeBlasio <jdeb...@chromium.org>
Gerrit-CC: Hubert Chao <hc...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 17:28:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 10, 2025, 2:32:31 PM (2 days ago) Oct 10
to Chrome Cherry Picker, Hubert Chao, Joe DeBlasio, David Benjamin, AyeAye, net-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M140] Fix owners file to include additional.certs; also remove old bot as we're on pod batch now.

Original change's description:
> Fix owners file to include additional.certs; also remove old bot as we're on pod batch now.
>
> Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6821577
> Commit-Queue: Hubert Chao <hc...@chromium.org>
> Reviewed-by: David Benjamin <davi...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1497097}

(cherry picked from commit 00c31668ba7ced0113e2c385eb29e0e5c4797997)
Bug: 449751913
Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
Reviewed-by: David Benjamin <davi...@chromium.org>
Commit-Queue: Joe DeBlasio <jdeb...@chromium.org>
Reviewed-by: Joe DeBlasio <jdeb...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7339@{#3568}
Cr-Branched-From: 27be8b77710f4405fdfeb4ee946fcabb0f6c92b2-refs/heads/main@{#1496484}
Files:
  • M net/data/ssl/chrome_root_store/OWNERS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 5 deletions(-)
Branch: refs/branch-heads/7339
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Benjamin, +1 by Joe DeBlasio
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7339
Gerrit-Change-Id: Idae80de337107011c1bcc0fc260d4aa4ac51c2d0
Gerrit-Change-Number: 7030407
Gerrit-PatchSet: 3
Gerrit-Reviewer: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Joe DeBlasio <jdeb...@chromium.org>
Gerrit-CC: Hubert Chao <hc...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages