[CodeHealth] Remove stale base::Feature PriorityHeader [chromium/src : main]
0 views
Skip to first unread message
Benjamin Keen (Gerrit)
Nov 8, 2024, 4:27:49 PM11/8/24
to Patrick Meenan, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Patrick Meenan
Benjamin Keen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Patrick Meenan
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Meenan (Gerrit)
Nov 8, 2024, 4:46:05 PM11/8/24
to Benjamin Keen, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Benjamin Keen
Patrick Meenan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Meenan
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Patrick Meenan . resolved
LGTM. Thanks for the cleanup - it had quite a few tendrils running into the tests.
Related details
Attention is currently required from:
- Benjamin Keen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Nov 8, 2024, 5:04:59 PM11/8/24
to Adam Rice, Dan Zhang, Patrick Meenan, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Adam Rice and Dan Zhang
Benjamin Keen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Patrick Meenan . resolved
LGTM. Thanks for the cleanup - it had quite a few tendrils running into the tests.
Attention is currently required from:
- Adam Rice
- Dan Zhang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Nov 13, 2024, 1:29:32 PM11/13/24
to Benjamin Keen, Code Review Nudger, Dan Zhang, Patrick Meenan, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Benjamin Keen and Dan Zhang
Adam Rice voted and added 2 comments![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
2 comments
Patchset-level comments
Adam Rice . resolved
lgtm, thanks for the cleanup!
File net/http/http_network_transaction_unittest.cc
Line 681, Patchset 2 (Parent):
if (PriorityHeaderEnabled()) {Adam Rice . unresolved
Please also remove `priority_header_enabled` from struct TestParams.
Related details
Attention is currently required from:
- Benjamin Keen
- Dan Zhang
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Nov 14, 2024, 10:36:15 AM11/14/24
to Adam Rice, Code Review Nudger, Dan Zhang, Patrick Meenan, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Attention needed from Benjamin Keen and Dan Zhang
Benjamin Keen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Benjamin Keen
| Commit-Queue | +1 |
1 comment
File net/http/http_network_transaction_unittest.cc
Line 681, Patchset 2 (Parent):
if (PriorityHeaderEnabled()) {Adam Rice . resolved
Please also remove `priority_header_enabled` from struct TestParams.
Benjamin Keen
Done. Tx for the review!
Related details
Attention is currently required from:
- Benjamin Keen
- Dan Zhang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Nov 15, 2024, 10:51:31 AM11/15/24
to Biren Roy, Dan Zhang, Adam Rice, Code Review Nudger, Patrick Meenan, AyeAye, Tricium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Benjamin Keen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 15, 2024, 11:02:19 AM11/15/24
to Benjamin Keen, Biren Roy, Dan Zhang, Adam Rice, Code Review Nudger, Patrick Meenan, AyeAye, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, ricea...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: net/http/http_network_transaction_unittest.cc
Insertions: 4, Deletions: 10.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[CodeHealth] Remove stale base::Feature PriorityHeader
This feature has been enabled by default since M124.
Fixed: 362247194
Change-Id: Ic83d73a096501f4222e71e273f82ab11bc3853e4
Reviewed-by: Patrick Meenan <pme...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Commit-Queue: Benjamin Keen <bk...@google.com>
Cr-Commit-Position: refs/heads/main@{#1383628}
Files:
- M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
- M net/base/features.cc
- M net/base/features.h
- M net/http/http_network_transaction_unittest.cc
- M net/quic/quic_http_stream_test.cc
- M net/quic/quic_network_transaction_unittest.cc
- M net/quic/quic_session_pool_test.cc
- M net/quic/quic_test_packet_maker.cc
- M net/spdy/spdy_http_stream_unittest.cc
- M net/spdy/spdy_http_utils.cc
- M net/spdy/spdy_http_utils_unittest.cc
- M net/spdy/spdy_network_transaction_unittest.cc
- M net/spdy/spdy_test_util_common.cc
- M net/websockets/websocket_stream_test.cc
- M testing/variations/fieldtrial_testing_config.json
Change size: L
Delta: 15 files changed, 53 insertions(+), 214 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Patrick Meenan, +1 by Adam Rice
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages