| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
lgtm % open comments
Hey Struan, many thanks for the comments as well:)
Enabled GN flag on Linux Code Coverage builder
Ignore-Freeze: True
Bug: 469798145
Signed-off-by: Manuel Briones <manuel...@google.com>Manuel Brionesnit: Looks like you've got two commit messages here pasted into one. I'd just remove this chunk. The remainder is sufficient as a commit msg for this CL.
Ohh I get it. My bad, this was my first commit and didn't know gerrit squashed them. Many thanks:)
version: "1.46.2"Manuel Briones"1.46.2" rolled out quite a while ago. And you can see this change already present on trunk:
https://chromium.googlesource.com/chromium/src/+/HEAD/infra/config/generated/luci/project.cfgI'd rebase your checkout and your CL. This diff should hopefully disappear after that. LMK if you need help rebasing.
Many thanks!! I wanted to do a `git pull --rebase origin main` on my local repo but instead I clicked on the "rebase" button in the UI. It's pretty cool btw! Again, many thanks:)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
lgtm, but you'll need an OWNER for the //build/config/coverage/ changes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
lgtm, but you'll need an OWNER for the //build/config/coverage/ changes
Thank you so much for the review:)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Enabled GN flag on Linux Code Coverage builder
Ignore-Freeze: True
Bug: 469798145
Signed-off-by: Manuel Briones <manuel...@google.com>Manuel Brionesnit: Looks like you've got two commit messages here pasted into one. I'd just remove this chunk. The remainder is sufficient as a commit msg for this CL.
Ohh I get it. My bad, this was my first commit and didn't know gerrit squashed them. Many thanks:)
Hi @bpas...@chromium.org @ssh...@google.com, apologies for the accidental upload! This patchset didn't change any code (it was a metadata/rebase error on my end). If the diff looks clear to you, would you mind re-applying your +1s? Sorry for the noise!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
Enabled GN flag on Linux Code Coverage builder
Ignore-Freeze: True
Bug: 469798145
Signed-off-by: Manuel Briones <manuel...@google.com>Manuel Brionesnit: Looks like you've got two commit messages here pasted into one. I'd just remove this chunk. The remainder is sufficient as a commit msg for this CL.
Manuel BrionesOhh I get it. My bad, this was my first commit and didn't know gerrit squashed them. Many thanks:)
Hi @bpas...@chromium.org @ssh...@google.com, apologies for the accidental upload! This patchset didn't change any code (it was a metadata/rebase error on my end). If the diff looks clear to you, would you mind re-applying your +1s? Sorry for the noise!
Done
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Add Single-byte coverage flag for Linux builders
Use single-byte coverage on LLVM[1] for a faster, light-weight,
yet efficient mechanism of counting line hit.
By replacing 8-byte counters with single-byte counters,
memory overhead is reduced during coverage builds.
[1] https://github.com/llvm/llvm-project/pull/75425
[2] https://discourse.llvm.org/t/rfc-single-byte-counters-for-source-based-code-coverage/75685/12
R=fzar...@google.com, manuel...@google.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |