Disable SendReportsAndRemoveSourceWithPendingReports, flaky in Chrome OS [chromium/src : main]

Vidhan Jain (Gerrit)

unread,

Aug 24, 2022, 7:58:29 AM8/24/22

to Florian Leimgruber, net-r...@chromium.org

Attention is currently required from: Florian Leimgruber.

Vidhan Jain would like Florian Leimgruber to review this change.

Disable SendReportsAndRemoveSourceWithPendingReports, flaky in Chrome OS

Bug: 1356127
Change-Id: I03de092551961b8e2a537491979547f0b767c713
---
M net/reporting/reporting_service_unittest.cc
1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/net/reporting/reporting_service_unittest.cc b/net/reporting/reporting_service_unittest.cc
index 4307df3..d7b1c81f 100644
--- a/net/reporting/reporting_service_unittest.cc
+++ b/net/reporting/reporting_service_unittest.cc
@@ -281,7 +281,16 @@
       context()->cache()->GetExpiredSources().contains(*kReportingSource_));
 }
 
-TEST_P(ReportingServiceTest, SendReportsAndRemoveSourceWithPendingReports) {
+// Flaky in ChromeOS: crbug.com/1356127
+#if BUILDFLAG(IS_CHROMEOS)
+#define MAYBE_SendReportsAndRemoveSourceWithPendingReports \
+  DISABLED_SendReportsAndRemoveSourceWithPendingReports
+#else
+#define MAYBE_SendReportsAndRemoveSourceWithPendingReports \
+  SendReportsAndRemoveSourceWithPendingReports
+#endif
+TEST_P(ReportingServiceTest,
+       MAYBE_SendReportsAndRemoveSourceWithPendingReports) {
   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(net::features::kDocumentReporting);
   auto parsed_header =

To view, visit change 3854089. To unsubscribe, or for help writing mail filters, visit settings.

Vidhan Jain (Gerrit)

unread,

Aug 24, 2022, 7:58:38 AM8/24/22

to net-r...@chromium.org, Florian Leimgruber, chromium...@chromium.org

Attention is currently required from: Florian Leimgruber.

Patch set 1:Owners-Override +1

View Change

To view, visit change 3854089. To unsubscribe, or for help writing mail filters, visit settings.

Vidhan Jain (Gerrit)

unread,

Aug 24, 2022, 8:05:09 AM8/24/22

to net-r...@chromium.org, Chromium LUCI CQ, Florian Leimgruber, chromium...@chromium.org

Attention is currently required from: Florian Leimgruber.

Patch set 1:Auto-Submit +1

View Change

To view, visit change 3854089. To unsubscribe, or for help writing mail filters, visit settings.

Florian Leimgruber (Gerrit)

unread,

Aug 24, 2022, 8:12:31 AM8/24/22

to Vidhan Jain, net-r...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Vidhan Jain.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 3854089. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Aug 24, 2022, 8:29:11 AM8/24/22

to Vidhan Jain, net-r...@chromium.org, Florian Leimgruber, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Vidhan Jain: Send CL to CQ automatically after approval; Dry run; Looks good to me
  Florian Leimgruber: Looks good to me; Commit

Disable SendReportsAndRemoveSourceWithPendingReports, flaky in Chrome OS

Bug: 1356127
Change-Id: I03de092551961b8e2a537491979547f0b767c713

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854089
Auto-Submit: Vidhan Jain <vid...@google.com>
Commit-Queue: Florian Leimgruber <fleim...@google.com>
Reviewed-by: Florian Leimgruber <fleim...@google.com>
Commit-Queue: Vidhan Jain <vid...@google.com>
Owners-Override: Vidhan Jain <vid...@google.com>
Cr-Commit-Position: refs/heads/main@{#1038725}
---
M net/reporting/reporting_service_unittest.cc
1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/net/reporting/reporting_service_unittest.cc b/net/reporting/reporting_service_unittest.cc
index 4307df3..d7b1c81f 100644
--- a/net/reporting/reporting_service_unittest.cc
+++ b/net/reporting/reporting_service_unittest.cc
@@ -281,7 +281,16 @@
       context()->cache()->GetExpiredSources().contains(*kReportingSource_));
 }
 
-TEST_P(ReportingServiceTest, SendReportsAndRemoveSourceWithPendingReports) {
+// Flaky in ChromeOS: crbug.com/1356127
+#if BUILDFLAG(IS_CHROMEOS)
+#define MAYBE_SendReportsAndRemoveSourceWithPendingReports \
+  DISABLED_SendReportsAndRemoveSourceWithPendingReports
+#else
+#define MAYBE_SendReportsAndRemoveSourceWithPendingReports \
+  SendReportsAndRemoveSourceWithPendingReports
+#endif
+TEST_P(ReportingServiceTest,
+       MAYBE_SendReportsAndRemoveSourceWithPendingReports) {
   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(net::features::kDocumentReporting);
   auto parsed_header =

To view, visit change 3854089. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward