Remove //net dependency from tld_cleanup [chromium/src : main]

0 views
Skip to first unread message

Chris Fredrickson (Gerrit)

unread,
Feb 18, 2026, 12:14:04 PM (3 days ago) Feb 18
to Adam Rice, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Adam Rice

Chris Fredrickson voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I607ae2eda23d39094090d79adc46f483924520e6
Gerrit-Change-Number: 7588178
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Feb 2026 17:13:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Rice (Gerrit)

unread,
Feb 20, 2026, 8:08:35 AM (yesterday) Feb 20
to Chris Fredrickson, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Chris Fredrickson

Adam Rice added 1 comment

File net/tools/tld_cleanup/tld_cleanup_util.cc
Line 24, Patchset 4 (Latest):// These constants must match those found in
Adam Rice . unresolved

Was it not possible to add lookup_string_in_fixed_set.h to the `net_deps` source_set()?

If we have to do this, then we should use IfThisThenThat to make sure both definitions stay in sync: https://www.chromium.org/chromium-os/developer-library/guides/development/keep-files-in-sync/

It's sadly under-documented, but there are lots of examples in the source tree.

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Fredrickson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I607ae2eda23d39094090d79adc46f483924520e6
    Gerrit-Change-Number: 7588178
    Gerrit-PatchSet: 4
    Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
    Gerrit-Attention: Chris Fredrickson <cfre...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 13:08:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chris Fredrickson (Gerrit)

    unread,
    Feb 20, 2026, 10:26:38 AM (yesterday) Feb 20
    to AyeAye, Adam Rice, Chromium LUCI CQ, chromium...@chromium.org, jdeblas...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
    Attention needed from Adam Rice

    Chris Fredrickson voted and added 1 comment

    Votes added by Chris Fredrickson

    Auto-Submit+1

    1 comment

    File net/tools/tld_cleanup/tld_cleanup_util.cc
    Line 24, Patchset 4:// These constants must match those found in
    Adam Rice . resolved

    Was it not possible to add lookup_string_in_fixed_set.h to the `net_deps` source_set()?

    If we have to do this, then we should use IfThisThenThat to make sure both definitions stay in sync: https://www.chromium.org/chromium-os/developer-library/guides/development/keep-files-in-sync/

    It's sadly under-documented, but there are lots of examples in the source tree.

    Chris Fredrickson

    Thanks for the pointer - I split out the constants to a new header and added that to the `constants` target (which is in the public_deps of `net_deps`).

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I607ae2eda23d39094090d79adc46f483924520e6
      Gerrit-Change-Number: 7588178
      Gerrit-PatchSet: 6
      Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Comment-Date: Fri, 20 Feb 2026 15:26:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages