Replace CompletionOnceCallback with ErrorCallback for FileStream operations [chromium/src : main]
0 views
Skip to first unread message
Helmut Januschka (Gerrit)
Feb 9, 2026, 3:53:27 PM (12 days ago) Feb 9
to Helmut Januschka, Tsuyoshi Horo, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Tsuyoshi Horo
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Helmut Januschka . resolved
hello @ho...@chromium.org thanks in advance for review.
please let me know if you want me to address anything!
Related details
Attention is currently required from:
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Harrington (Gerrit)
Feb 9, 2026, 4:20:15 PM (12 days ago) Feb 9
to Helmut Januschka, Dan Harrington, Emilia Paz, Tsuyoshi Horo, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Emilia Paz, Helmut Januschka and Tsuyoshi Horo
Dan Harrington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Emilia Paz
- Helmut Januschka
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Feb 9, 2026, 4:42:00 PM (12 days ago) Feb 9
to Helmut Januschka, Dan Harrington, Tsuyoshi Horo, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Helmut Januschka and Tsuyoshi Horo
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Helmut Januschka
- Tsuyoshi Horo
Tsuyoshi Horo (Gerrit)
Feb 11, 2026, 11:32:57 PM (9 days ago) Feb 11
to Helmut Januschka, Dan Harrington, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Helmut Januschka
Tsuyoshi Horo voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Code-Review | +1 |
2 comments
Patchset-level comments
Tsuyoshi Horo . resolved
lgtm
File net/base/mock_file_stream.h
Line 25, Patchset 3 (Latest):
class MockFileStream : public FileStream {Tsuyoshi Horo . unresolved
It seems that the MockFileStream class is no longer being used. Could you please delete net/base/mock_file_stream.h and net/base/mock_file_stream.cc? Doing this in a follow-up CL after this one lands is fine with me.
Related details
Attention is currently required from:
- Helmut Januschka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Feb 19, 2026, 4:06:48 PM (2 days ago) Feb 19
to Helmut Januschka, Tsuyoshi Horo, Dan Harrington, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Dan Harrington, Helmut Januschka and Tsuyoshi Horo
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
Attention is currently required from:
- Dan Harrington
- Helmut Januschka
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Harrington (Gerrit)
Feb 19, 2026, 4:08:36 PM (2 days ago) Feb 19
to Helmut Januschka, Dan Harrington, Tsuyoshi Horo, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Helmut Januschka and Tsuyoshi Horo
Dan Harrington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Helmut Januschka
- Tsuyoshi Horo
Helmut Januschka (Gerrit)
Feb 19, 2026, 4:32:07 PM (2 days ago) Feb 19
to Helmut Januschka, Dan Harrington, Emilia Paz, Tsuyoshi Horo, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Dan Harrington, Emilia Paz and Tsuyoshi Horo
Helmut Januschka added 1 comment![]( "Open in Gerrit")
File net/base/mock_file_stream.h
It seems that the MockFileStream class is no longer being used. Could you please delete net/base/mock_file_stream.h and net/base/mock_file_stream.cc? Doing this in a follow-up CL after this one lands is fine with me.
Helmut Januschka
removed them, splitting is more pain than gain in that case i guess!
Related details
Attention is currently required from:
- Dan Harrington
- Emilia Paz
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Feb 19, 2026, 10:15:05 PM (2 days ago) Feb 19
to Helmut Januschka, Dan Harrington, Emilia Paz, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Dan Harrington, Emilia Paz and Helmut Januschka
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Code-Review | +1 |
Tsuyoshi Horo . resolved
lgtm
Attention is currently required from:
- Dan Harrington
- Emilia Paz
- Helmut Januschka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Feb 20, 2026, 12:43:27 PM (20 hours ago) Feb 20
to Helmut Januschka, Tsuyoshi Horo, Dan Harrington, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Dan Harrington and Helmut Januschka
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dan Harrington
- Helmut Januschka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Feb 20, 2026, 3:08:20 PM (18 hours ago) Feb 20
to Helmut Januschka, Tsuyoshi Horo, Dan Harrington, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Attention needed from Dan Harrington
Helmut Januschka voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dan Harrington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 3:59:21 PM (17 hours ago) Feb 20
to Helmut Januschka, Emilia Paz, Tsuyoshi Horo, Dan Harrington, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, net-r...@chromium.org, storage...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace CompletionOnceCallback with ErrorCallback for FileStream operations
Modernize FileStream::Open(), Close(), Flush(), GetFileInfo(), and
ConnectNamedPipe() to use a typed ErrorCallback (OnceCallback<void(
net::Error)>) instead of the deprecated CompletionOnceCallback which
overloads int for both error codes and success.
Bug: 471017624
Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0
Reviewed-by: Emilia Paz <emil...@chromium.org>
Commit-Queue: Helmut Januschka <hel...@januschka.com>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1588001}
Files:
- M chrome/browser/extensions/api/messaging/launch_context.h
- M chrome/browser/extensions/api/messaging/launch_context_win.cc
- M chrome/browser/offline_pages/offline_page_request_handler.cc
- M net/base/file_stream.cc
- M net/base/file_stream.h
- M net/base/file_stream_unittest.cc
- M net/base/upload_file_element_reader.cc
- M net/test/url_request/url_request_test_job_backed_by_file.cc
- M net/test/url_request/url_request_test_job_backed_by_file.h
- M storage/browser/file_system/local_file_stream_reader.cc
- M storage/browser/file_system/local_file_stream_reader.h
- M storage/browser/file_system/local_file_stream_writer.cc
- M storage/browser/file_system/local_file_stream_writer.h
Change size: M
Delta: 13 files changed, 114 insertions(+), 62 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz, +1 by Tsuyoshi Horo
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages