Remove uses of std::unique_ptr<base::Value> for SPDY session state. [chromium/src : main]
0 views
Skip to first unread message
mmenke (Gerrit)
Dec 18, 2025, 2:37:43 PM (2 days ago) Dec 18
to Adam Rice, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Adam Rice
mmenke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
mmenke . resolved
[ricea] PTAL. Had a little time to kill last Friday afternoon.
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Dec 19, 2025, 4:46:46 AM (2 days ago) Dec 19
to Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from mmenke
Adam Rice voted and added 2 comments![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
2 comments
Patchset-level comments
Adam Rice . resolved
lgtm, thanks!
File net/spdy/spdy_session_pool.cc
Line 533, Patchset 1 (Latest):
base::Value::List list;Adam Rice . unresolved
While we are in the neighbourhood:
```suggestion
auto list = base::Value::List::with_capacity(sessions_.size());
```
Related details
Attention is currently required from:
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Dec 19, 2025, 11:32:53 AM (2 days ago) Dec 19
to Adam Rice, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
mmenke voted and added 2 comments![]( "Open in Gerrit")
Votes added by mmenke
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File net/spdy/spdy_session_pool.cc
While we are in the neighbourhood:
```suggestion
auto list = base::Value::List::with_capacity(sessions_.size());
```
mmenke
Done, though I am skeptical it's worth the complexity to very slightly optimize something that likely only happens less than once every 1,000 executions of Chrome's binary. Yes, it's very small decrease in readability, but the gains here are also basically 0.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 19, 2025, 12:27:35 PM (2 days ago) Dec 19
to Adam Rice, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: net/spdy/spdy_session_pool.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Remove uses of std::unique_ptr<base::Value> for SPDY session state.
base::Value is preferred, to avoid the memory allocation overhead.
Bug: 40258809
Change-Id: I08245e2ae49e8402e9fe5a2c4d93779e6132d968
Commit-Queue: mmenke <mme...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561203}
Files:
- M net/http/http_network_session.cc
- M net/http/http_network_session.h
- M net/http/http_stream_factory_unittest.cc
- M net/log/net_log_util.cc
- M net/spdy/spdy_network_transaction_unittest.cc
- M net/spdy/spdy_session_pool.cc
- M net/spdy/spdy_session_pool.h
Change size: S
Delta: 7 files changed, 15 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Rice
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages