Revert "Roll src/net/third_party/quiche/src/ 2a5b508d7..958d7e734 (20 commits)" [chromium/src : main]
0 views
Skip to first unread message
Mark Pearson (Gerrit)
Oct 10, 2025, 9:01:01 PM (2 days ago) Oct 10
to Rubber Stamper, Lily Chen, Chromium LUCI CQ, Ryan Hamilton, AyeAye, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Lily Chen and Ryan Hamilton
Mark Pearson voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Lily Chen
- Ryan Hamilton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Oct 10, 2025, 9:01:25 PM (2 days ago) Oct 10
to Mark Pearson, Lily Chen, Chromium LUCI CQ, Ryan Hamilton, AyeAye, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Lily Chen and Ryan Hamilton
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Lily Chen
- Ryan Hamilton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Pearson (Gerrit)
Oct 10, 2025, 9:05:12 PM (2 days ago) Oct 10
to Rubber Stamper, Lily Chen, Chromium LUCI CQ, Ryan Hamilton, AyeAye, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Lily Chen and Ryan Hamilton
Mark Pearson voted![]( "Open in Gerrit")
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Lily Chen
- Ryan Hamilton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 10, 2025, 9:05:48 PM (2 days ago) Oct 10
to Mark Pearson, Rubber Stamper, Lily Chen, Ryan Hamilton, AyeAye, chromium...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Roll src/net/third_party/quiche/src/ 2a5b508d7..958d7e734 (20 commits)"
This reverts commit 492f35017a461fffce930ccb9f18fbdae701fc7d.
Reason for revert:
The new test
TlsHandshakerTests/TlsClientHandshakerTest.SetCompliancePolicyCnsa202407/*
consistently fails on two MSan bots.
Specifically, these tests fail:
net_unittests failed because of:
TlsHandshakerTests/TlsClientHandshakerTest.SetCompliancePolicyCnsa202407/RFCv1
TlsHandshakerTests/TlsClientHandshakerTest.SetCompliancePolicyCnsa202407/RFCv2
TlsHandshakerTests/TlsClientHandshakerTest.SetCompliancePolicyCnsa202407/draft29
On these two bots:
- Linux MSan Tests
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests
- Linux ChromiumOS MSan Tests
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests
This test was added in
https://quiche.googlesource.com/quiche.git/+/958d7e734101e35d3c5c2fbffac5654492307dd4
which is part of this roll.
All three failures on all two bots are identical:
---
tls_client_handshaker_test.cc(1023): Expected equality of these values:
stream()->crypto_negotiated_params().cipher_suite
Which is: 4867
0x03001302 & 0xffff
Which is: 4866
---
Original change's description:
> Roll src/net/third_party/quiche/src/ 2a5b508d7..958d7e734 (20 commits)
>
> https://quiche.googlesource.com/quiche.git/+log/2a5b508d74f1..958d7e734101
>
> $ git log 2a5b508d7..958d7e734 --date=short --no-merges --format='%ad %ae %s'
> 2025-10-10 quiche-dev Support configuring client key shares and SSL compliance policy
> 2025-10-09 danzh Make QuicClientBase use `QuicForceBlockablePacketWriter` to wrap whatever writer instance provided by network helper and owns the instance. This is necessary to support connection and port migration, as the migration manager requires the ability to temporarily block writes. This is controlled a new interface set_handle_migration_in_session() in client.
> 2025-10-09 dmcardle Define AbslStringify() for quic::SendAlgorithmInterface::NetworkParams
> 2025-10-09 jprat No public description
> 2025-10-07 martinduke No public description
> 2025-10-07 martinduke Repro for b/440033781.
> 2025-10-07 quiche-dev No public description
> 2025-10-06 martinduke Rename NamespaceTree to SessionNamespaceTree.
> 2025-10-06 davidben Use `TLSEXT_TYPE_quic_transport_parameters` instead of `TLSEXT_TYPE_quic_transport_parameters_standard`
> 2025-10-06 vasilvv Add support for operator== and absl::Hash to QuicheWeakPtr.
> 2025-10-06 quiche-dev Inline unique_ptr field(s) to improve data locality.
> 2025-10-06 martinduke Add instructions for building and running standalone QUICHE.
> 2025-10-06 martinduke Rename NamespacePublisherMultimap to RelayNamespaceTree.
> 2025-10-05 jprat Delay closing QUIC connections on invalid SNI and log the normalized SNI.
> 2025-10-03 dmcardle Replace some trivial comparisons with C++20 default comparisons
> 2025-10-02 ripere Log the HTTP status code of the decoded OHTTP response.
> 2025-10-02 martinduke Fix MSAN error in ChatClient.
> 2025-10-01 martinduke fix fuzzing error introduced by cl/800613375
> 2025-10-01 danzh A few changes to connection migration code which is not being used:
> 2025-10-01 quiche-dev Fix typo in comment: "textural" -> "textual".
>
> Created with:
> roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
>
> Change-Id: I0af8773434c5e8b690408e3449e5c7b029660bec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032900
> Reviewed-by: Ryan Hamilton <r...@chromium.org>
> Auto-Submit: Lily Chen <chl...@chromium.org>
> Commit-Queue: Ryan Hamilton <r...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1528340}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I145af80c96a19f1b12b4566864571657e3b7a00a
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Mark Pearson <mpea...@chromium.org>
Auto-Submit: Mark Pearson <mpea...@chromium.org>
Owners-Override: Mark Pearson <mpea...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528472}
Files:
- M DEPS
- M net/third_party/quiche/src
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages