Let QUIC send connection option NIPA by default. [chromium/src : main]

0 views

Skip to first unread message

Fan Yang (Gerrit)

unread,

Dec 19, 2025, 7:55:07 PM (2 days ago) Dec 19

to Ryan Hamilton, Ian Swett, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org

Attention needed from Ian Swett and Ryan Hamilton

Fan Yang voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Ian Swett
Ryan Hamilton

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ian Swett (Gerrit)

unread,

Dec 20, 2025, 1:43:44 PM (12 hours ago) Dec 20

to Fan Yang, Ryan Hamilton, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org

Attention needed from Fan Yang and Ryan Hamilton

Ian Swett added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Ian Swett . resolved

I think I understand, but can you confirm that the new code is doing what I think? Also, since you're using it in 3 spots, does it make sense to add a convenience method?

File components/cronet/url_request_context_config.cc

Line 480, Patchset 2 (Latest): for (const auto& option :

Ian Swett . unresolved

Can you add a comment? Is this trying to merge the existing connection options with the parsed connection options?