Add UMA histogram for Disk Cache init time [chromium/src : main]

0 views

Skip to first unread message

Maks Orlovich (Gerrit)

unread,

Dec 19, 2025, 10:31:26 AM (2 days ago) Dec 19

to Alex Valadkevich, David Schinazi, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, asvitkine...@chromium.org, net-r...@chromium.org, gavin...@chromium.org

Attention needed from Alex Valadkevich and David Schinazi

Maks Orlovich added 2 comments

File net/disk_cache/disk_cache.cc

Line 117, Patchset 3 (Latest): base::Time init_start_time_;

Maks Orlovich . unresolved

TimeTicks; you want a monotonic clock, not human time.

File tools/metrics/histograms/metadata/net/histograms.xml

Line 1319, Patchset 3 (Latest): <summary>The time taken to initialize the disk cache.</summary>

Maks Orlovich . unresolved

I think it may be good to be more precise --- e.g. that this is at disk_cache::CreateCacheBackend level --- since backends may have non-blocking portions of initialization that is still going on..

Open in Gerrit

Related details

Attention is currently required from:

Alex Valadkevich
David Schinazi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Schinazi (Gerrit)

unread,

Dec 19, 2025, 2:50:34 PM (2 days ago) Dec 19

to Alex Valadkevich, Maks Orlovich, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, asvitkine...@chromium.org, net-r...@chromium.org, gavin...@chromium.org

Attention needed from Alex Valadkevich

David Schinazi voted and added 1 comment

Votes added by David Schinazi

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

David Schinazi . resolved

+1 to comments from Maks, but LGTM once those are resolved