[base] Update AmountOf{Total,Free}DiskSpace to return std::optional [chromium/src : main]

0 views
Skip to first unread message

Thiabaud Engelbrecht (Gerrit)

unread,
Oct 10, 2025, 1:24:19 PM (2 days ago) Oct 10
to Francois Pierre Doray, Enterprise Policy Reviews, Zijie He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ajayramamurthy...@google.com, jonmann+wat...@chromium.org, joeantonetti+...@google.com, pushi+watc...@google.com, jackshira+wa...@google.com, hansberry+wa...@chromium.org, crisrael+wa...@google.com, pushi+wat...@google.com, hansberry+w...@chromium.org, hais+wat...@google.com, xlythe+wa...@google.com, jackshira+w...@google.com, hansenmichael...@google.com, ajayramamurth...@google.com, tbarzi...@chromium.org, cros-report...@google.com, dclasson+w...@google.com, crisrael+w...@google.com, suetfei+wa...@google.com, asvitki...@chromium.org, chromiumme...@microsoft.com, phshah...@chromium.org, alandin...@chromium.org, jackshira+wat...@google.com, wfh+...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, arc-review...@google.com, roblia...@chromium.org, yhanada+...@chromium.org, jessemcke...@google.com, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, mac-r...@chromium.org, rginda...@chromium.org, filesapp...@chromium.org, dtraino...@chromium.org, chromeos-kio...@google.com, fuchsia...@chromium.org, oshima...@chromium.org, chili...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, dimich...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, extension...@chromium.org, fgorsk...@chromium.org, gavin...@chromium.org, net-r...@chromium.org, performance-m...@chromium.org, thiabaud+watch-d...@google.com
Attention needed from Francois Pierre Doray

Thiabaud Engelbrecht added 2 comments

File base/system/sys_info_posix.cc
Line 220, Patchset 17 (Latest): return available;
Thiabaud Engelbrecht . unresolved

Maybe add a DCHECK here to assert that the return value is non-negative?

Line 232, Patchset 17 (Latest): return total;
Thiabaud Engelbrecht . unresolved

And also one here?

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ec49a45929b0af091224509728a72e61726ccf0
Gerrit-Change-Number: 7003995
Gerrit-PatchSet: 17
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 17:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages