Revert "[task] Inject ThreadDelegate through Thread constructor" [chromium/src : main]

0 views
Skip to first unread message

Brian Sheedy (Gerrit)

unread,
Apr 2, 2026, 10:11:45 PM (3 days ago) Apr 2
to Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Colin Blundell, Etienne Pierre-Doray, Dale Curtis, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
Attention needed from Alex Gough, Alex N. Jose, Colin Blundell, Dale Curtis, Dave Tapuska, Etienne Pierre-Doray, Gabriel Charette and Simeon Anfinrud

Brian Sheedy added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brian Sheedy . resolved

The trace test step passed on the affected trybot with this revert in place, so this does appear to be the cause of the test failure. I'll defer to the author + reviewers whether the failure seems important enough to warrant a revert vs. marking the test as expected to fail.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • Alex N. Jose
  • Colin Blundell
  • Dale Curtis
  • Dave Tapuska
  • Etienne Pierre-Doray
  • Gabriel Charette
  • Simeon Anfinrud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie903f0d19d6ef8acaa7f921b6489a7e97bdb7f3d
Gerrit-Change-Number: 7727694
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Alex N. Jose <ale...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Attention: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Alex N. Jose <ale...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Attention: Alex Gough <aj...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 02:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Apr 2, 2026, 10:12:13 PM (3 days ago) Apr 2
to Brian Sheedy, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Colin Blundell, Etienne Pierre-Doray, Dale Curtis, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
Attention needed from Alex Gough, Alex N. Jose, Colin Blundell, Dale Curtis, Dave Tapuska, Etienne Pierre-Doray, Gabriel Charette and Simeon Anfinrud

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • Alex N. Jose
  • Colin Blundell
  • Dale Curtis
  • Dave Tapuska
  • Etienne Pierre-Doray
  • Gabriel Charette
  • Simeon Anfinrud
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Comment-Date: Fri, 03 Apr 2026 02:12:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Apr 2, 2026, 10:13:10 PM (3 days ago) Apr 2
    to Brian Sheedy, Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Colin Blundell, Etienne Pierre-Doray, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
    Attention needed from Alex Gough, Alex N. Jose, Brian Sheedy, Colin Blundell, Dave Tapuska, Etienne Pierre-Doray, Gabriel Charette and Simeon Anfinrud

    Dale Curtis voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Alex N. Jose
    • Brian Sheedy
    • Colin Blundell
    Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 02:13:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    Apr 3, 2026, 2:28:18 AM (3 days ago) Apr 3
    to Brian Sheedy, Colin Blundell, Dale Curtis, Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Etienne Pierre-Doray, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
    Attention needed from Alex Gough, Alex N. Jose, Brian Sheedy, Dave Tapuska, Etienne Pierre-Doray, Gabriel Charette and Simeon Anfinrud

    Colin Blundell voted and added 1 comment

    Votes added by Colin Blundell

    Code-Review+1

    1 comment

    Patchset-level comments
    Colin Blundell . resolved

    I think that we should revert given that it looks like the failure is deterministic. Not going to push it through though as the original CL mentions a followup CL.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Alex N. Jose
    • Brian Sheedy
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 06:27:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Apr 3, 2026, 8:04:06 AM (3 days ago) Apr 3
    to Brian Sheedy, Colin Blundell, Dale Curtis, Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
    Attention needed from Alex Gough, Alex N. Jose, Brian Sheedy, Dave Tapuska, Gabriel Charette and Simeon Anfinrud

    Etienne Pierre-Doray voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Alex N. Jose
    • Brian Sheedy
    • Dave Tapuska
    • Gabriel Charette
    • Simeon Anfinrud
    Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 12:03:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Apr 3, 2026, 8:30:02 AM (3 days ago) Apr 3
    to Brian Sheedy, Colin Blundell, Dale Curtis, Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
    Attention needed from Alex Gough, Alex N. Jose, Brian Sheedy, Dave Tapuska, Gabriel Charette and Simeon Anfinrud

    Etienne Pierre-Doray added 1 comment

    Patchset-level comments
    Etienne Pierre-Doray . resolved

    I also have a forward fix that might create less churn: https://crrev.com/c/7728065

    Gerrit-Comment-Date: Fri, 03 Apr 2026 12:29:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    Apr 3, 2026, 8:45:54 AM (3 days ago) Apr 3
    to Brian Sheedy, Etienne Pierre-Doray, Colin Blundell, Dale Curtis, Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Alex N. Jose, Chromium LUCI CQ, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
    Attention needed from Alex Gough, Alex N. Jose, Brian Sheedy, Dave Tapuska, Gabriel Charette and Simeon Anfinrud

    Colin Blundell added 1 comment

    Patchset-level comments
    Etienne Pierre-Doray . resolved

    I also have a forward fix that might create less churn: https://crrev.com/c/7728065

    Colin Blundell

    Thanks! Let's go with that since this is an FYI bot.

    Gerrit-Comment-Date: Fri, 03 Apr 2026 12:45:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex N. Jose (Gerrit)

    unread,
    Apr 3, 2026, 2:19:46 PM (2 days ago) Apr 3
    to Brian Sheedy, Etienne Pierre-Doray, Colin Blundell, Dale Curtis, Rubber Stamper, Simeon Anfinrud, Gabriel Charette, Chromium LUCI CQ, Dave Tapuska, Alex Gough, AyeAye, Thiabaud Engelbrecht, devtools...@chromium.org, Mathias Bynens, chromium...@chromium.org, Sean Maher, spang...@chromium.org, olka+...@chromium.org, net-r...@chromium.org, scheduler...@chromium.org, feature-me...@chromium.org, mpdento...@chromium.org, marinacio...@chromium.org, scheduler-b...@chromium.org, halliwe...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, rsesek...@chromium.org
    Attention needed from Alex Gough, Brian Sheedy, Dave Tapuska, Gabriel Charette and Simeon Anfinrud

    Alex N. Jose voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 18:19:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages