Make gn2bp use the linker_scripts property [chromium/src : main]

0 views

Skip to first unread message

Cole Faust (Gerrit)

unread,

Apr 2, 2026, 8:56:52 PM (3 days ago) Apr 2

to chromium...@chromium.org, net-r...@chromium.org

Cole Faust added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Cole Faust . resolved

I'm running presubmits from this change on https://googleplex-android-review.git.corp.google.com/c/platform/external/cronet/+/39268524

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Cole Faust (Gerrit)

unread,

Apr 3, 2026, 1:44:07 PM (2 days ago) Apr 3

to Mohannad Farrag, chromium...@chromium.org, net-r...@chromium.org

Attention needed from Mohannad Farrag

Cole Faust voted and added 1 comment

Votes added by Cole Faust

Auto-Submit

1 comment

Patchset-level comments

File-level comment, Patchset 1:

Cole Faust . resolved

I'm running presubmits from this change on https://googleplex-android-review.git.corp.google.com/c/platform/external/cronet/+/39268524

Cole Faust

For patchset 2:
https://googleplex-android-review.git.corp.google.com/c/platform/external/cronet/+/39270299

Both runs passed, patchset 2 just minimizes the changes from what currently exists.

Open in Gerrit

Related details

Attention is currently required from:

Mohannad Farrag

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages