Forward declare SingleThreadTaskRunner and SequencedTaskRunner [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Dec 17, 2025, 4:09:18 PM (3 days ago) Dec 17
to Lei Zhang, srirama chandra sekhar, AyeAye, Chromium LUCI CQ, eric.c...@apple.com, blink-re...@chromium.org, ozone-...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org, hashimo...@chromium.org, extension...@chromium.org, devtools...@chromium.org, jessemcke...@google.com, net-r...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, fdoray...@chromium.org, scheduler...@chromium.org, asvitki...@chromium.org, gab+...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com

Lei Zhang voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf
Gerrit-Change-Number: 7257184
Gerrit-PatchSet: 5
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Comment-Date: Wed, 17 Dec 2025 21:09:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 17, 2025, 4:56:16 PM (3 days ago) Dec 17
to Lei Zhang, Daniel Cheng, srirama chandra sekhar, AyeAye, Chromium LUCI CQ, eric.c...@apple.com, blink-re...@chromium.org, ozone-...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org, hashimo...@chromium.org, extension...@chromium.org, devtools...@chromium.org, jessemcke...@google.com, net-r...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, fdoray...@chromium.org, scheduler...@chromium.org, asvitki...@chromium.org, gab+...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Lei Zhang . resolved

Please OO+1. CQ may be wedged here.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf
Gerrit-Change-Number: 7257184
Gerrit-PatchSet: 5
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 21:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 18, 2025, 11:02:06 AM (3 days ago) Dec 18
to Lei Zhang, Daniel Cheng, srirama chandra sekhar, AyeAye, Chromium LUCI CQ, eric.c...@apple.com, blink-re...@chromium.org, ozone-...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org, hashimo...@chromium.org, extension...@chromium.org, devtools...@chromium.org, jessemcke...@google.com, net-r...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, fdoray...@chromium.org, scheduler...@chromium.org, asvitki...@chromium.org, gab+...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com
Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf
Gerrit-Change-Number: 7257184
Gerrit-PatchSet: 5
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:01:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 19, 2025, 11:10:40 AM (2 days ago) Dec 19
to Lei Zhang, Daniel Cheng, Wang, Wei4, Arnaud Mandy, Simon Hangl, Raphael Kubo da Costa, Peter Beverloo, Kenneth R Christiansen, Andrew Rayskiy, srirama chandra sekhar, AyeAye, Chromium LUCI CQ, cros-print...@google.com, print-rev...@chromium.org, mattreyno...@chromium.org, nator...@chromium.org, rmcelra...@chromium.org, sloboda...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, eric.c...@apple.com, blink-re...@chromium.org, ozone-...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org, hashimo...@chromium.org, extension...@chromium.org, devtools...@chromium.org, jessemcke...@google.com, net-r...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, fdoray...@chromium.org, scheduler...@chromium.org, asvitki...@chromium.org, gab+...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com
Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf
Gerrit-Change-Number: 7257184
Gerrit-PatchSet: 7
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 16:10:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 19, 2025, 11:57:55 AM (2 days ago) Dec 19
to Lei Zhang, Daniel Cheng, Wang, Wei4, Arnaud Mandy, Simon Hangl, Raphael Kubo da Costa, Peter Beverloo, Kenneth R Christiansen, Andrew Rayskiy, srirama chandra sekhar, AyeAye, Chromium LUCI CQ, cros-print...@google.com, print-rev...@chromium.org, mattreyno...@chromium.org, nator...@chromium.org, rmcelra...@chromium.org, sloboda...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, eric.c...@apple.com, blink-re...@chromium.org, ozone-...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org, hashimo...@chromium.org, extension...@chromium.org, devtools...@chromium.org, jessemcke...@google.com, net-r...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, fdoray...@chromium.org, scheduler...@chromium.org, asvitki...@chromium.org, gab+...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Commit-Queue+2

1 comment

Patchset-level comments
Lei Zhang . resolved

Please OO+1. CQ may be wedged here.

Lei Zhang

Thanks for the second round of reviews. I guess I had more changes stashed away in my local branch.

Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Fri, 19 Dec 2025 16:57:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 19, 2025, 12:03:37 PM (2 days ago) Dec 19
to Lei Zhang, Daniel Cheng, Wang, Wei4, Arnaud Mandy, Simon Hangl, Raphael Kubo da Costa, Peter Beverloo, Kenneth R Christiansen, Andrew Rayskiy, srirama chandra sekhar, AyeAye, cros-print...@google.com, print-rev...@chromium.org, mattreyno...@chromium.org, nator...@chromium.org, rmcelra...@chromium.org, sloboda...@chromium.org, rayanka...@chromium.org, storage...@chromium.org, eric.c...@apple.com, blink-re...@chromium.org, ozone-...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, chikamu...@chromium.org, hashimo...@chromium.org, extension...@chromium.org, devtools...@chromium.org, jessemcke...@google.com, net-r...@chromium.org, roblia...@chromium.org, gavin...@chromium.org, fdoray...@chromium.org, scheduler...@chromium.org, asvitki...@chromium.org, gab+...@chromium.org, oshima...@chromium.org, chromium-a...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Forward declare SingleThreadTaskRunner and SequencedTaskRunner

In various headers, forward declare SingleThreadTaskRunner and
SequencedTaskRunner. Then do IWYU to fix the build.
Change-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf
Commit-Queue: Lei Zhang <the...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561189}
Files:
  • M base/metrics/user_metrics.h
  • M base/observer_list_threadsafe.h
  • M base/one_shot_event.h
  • M base/task/current_thread.h
  • M base/task/thread_pool.h
  • M chromeos/dbus/common/blocking_method_caller.cc
  • M components/keyed_service/core/refcounted_keyed_service.h
  • M components/ui_devtools/devtools_server.h
  • M content/public/renderer/render_frame.h
  • M dbus/object_manager.cc
  • M dbus/object_proxy.h
  • M extensions/browser/api/messaging/native_message_host.h
  • M gpu/command_buffer/service/shared_context_state.h
  • M media/base/renderer_factory.h
  • M net/base/task/task_runner.h
  • M net/disk_cache/disk_cache.h
  • M third_party/blink/public/platform/browser_interface_broker_proxy.h
  • M third_party/blink/public/platform/modules/mediastream/web_platform_media_stream_source.h
  • M third_party/blink/public/platform/web_content_decryption_module_access.h
  • M third_party/blink/renderer/modules/ai/ai_interface_proxy.cc
  • M third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
  • M third_party/blink/renderer/modules/compute_pressure/pressure_observer_manager.cc
  • M third_party/blink/renderer/modules/direct_sockets/socket.cc
  • M third_party/blink/renderer/modules/file_system_access/file_system_access_manager.cc
  • M third_party/blink/renderer/modules/payments/payment_manager.cc
  • M third_party/blink/renderer/modules/printing/web_printing_manager.cc
  • M third_party/blink/renderer/modules/serial/serial_port.cc
  • M third_party/blink/renderer/modules/shapedetection/barcode_detector_statics.cc
  • M third_party/blink/renderer/modules/wake_lock/wake_lock_manager.cc
  • M third_party/blink/renderer/modules/webgl/webgl_context_object_support.h
  • M third_party/blink/renderer/platform/mojo/browser_interface_broker_proxy_impl.h
  • M third_party/blink/renderer/platform/mojo/mojo_binding_context.cc
  • M third_party/blink/renderer/platform/scheduler/public/frame_or_worker_scheduler.h
  • M third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h
  • M ui/base/pointer/touch_ui_controller.cc
  • M ui/ozone/public/platform_user_input_monitor.h
Change size: M
Delta: 36 files changed, 74 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2044abb7ed35f46b91e98f91eae5f329082e3edf
Gerrit-Change-Number: 7257184
Gerrit-PatchSet: 8
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages