Replace DownloadToString...CrashAndDie calls with DownloadHeadersOnly [chromium/src : main]

0 views
Skip to first unread message

Andrew Williams (Gerrit)

unread,
Dec 17, 2025, 9:11:44 AM (4 days ago) Dec 17
to Maks Orlovich, AyeAye, Chromium LUCI CQ, bnc+...@chromium.org, rginda...@chromium.org, chrome-intelligence-te...@google.com, network-ser...@chromium.org, chrome-intell...@chromium.org, xinghui...@chromium.org, asvitki...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, chromiumme...@microsoft.com, druber...@chromium.org, zackha...@chromium.org, net-r...@chromium.org
Attention needed from Maks Orlovich

Andrew Williams added 1 comment

Patchset-level comments
File-level comment, Patchset 1:
Andrew Williams . resolved

Hi Maks, would you mind taking a look at this overall to double-check that I converted these over correctly? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Maks Orlovich
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6bbfb1cf33337291b08a0dfb5a5783433ceba156
Gerrit-Change-Number: 7266460
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-Attention: Maks Orlovich <morl...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 14:11:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Maks Orlovich (Gerrit)

unread,
Dec 17, 2025, 10:20:13 AM (4 days ago) Dec 17
to Andrew Williams, AyeAye, Chromium LUCI CQ, bnc+...@chromium.org, rginda...@chromium.org, chrome-intelligence-te...@google.com, network-ser...@chromium.org, chrome-intell...@chromium.org, xinghui...@chromium.org, asvitki...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, chromiumme...@microsoft.com, druber...@chromium.org, zackha...@chromium.org, net-r...@chromium.org
Attention needed from Andrew Williams

Maks Orlovich voted and added 1 comment

Votes added by Maks Orlovich

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Maks Orlovich . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Williams
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6bbfb1cf33337291b08a0dfb5a5783433ceba156
    Gerrit-Change-Number: 7266460
    Gerrit-PatchSet: 3
    Gerrit-Owner: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Attention: Andrew Williams <awi...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Dec 2025 15:20:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maks Orlovich (Gerrit)

    unread,
    Dec 19, 2025, 10:27:44 AM (2 days ago) Dec 19
    to Andrew Williams, AyeAye, Chromium LUCI CQ, bnc+...@chromium.org, rginda...@chromium.org, chrome-intelligence-te...@google.com, network-ser...@chromium.org, chrome-intell...@chromium.org, xinghui...@chromium.org, asvitki...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, chromiumme...@microsoft.com, druber...@chromium.org, zackha...@chromium.org, net-r...@chromium.org
    Attention needed from Andrew Williams

    Maks Orlovich voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Williams
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6bbfb1cf33337291b08a0dfb5a5783433ceba156
    Gerrit-Change-Number: 7266460
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Attention: Andrew Williams <awi...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 15:27:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Andrew Williams (Gerrit)

    unread,
    Dec 19, 2025, 11:21:57 AM (2 days ago) Dec 19
    to Maks Orlovich, AyeAye, Chromium LUCI CQ, bnc+...@chromium.org, rginda...@chromium.org, chrome-intelligence-te...@google.com, network-ser...@chromium.org, chrome-intell...@chromium.org, xinghui...@chromium.org, asvitki...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, chromiumme...@microsoft.com, druber...@chromium.org, zackha...@chromium.org, net-r...@chromium.org

    Andrew Williams voted and added 1 comment

    Votes added by Andrew Williams

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Andrew Williams . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6bbfb1cf33337291b08a0dfb5a5783433ceba156
    Gerrit-Change-Number: 7266460
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 16:21:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages