Add cert_verify_tool option to disable net fetcher. [chromium/src : main]

0 views

Skip to first unread message

Nick Harper (Gerrit)

unread,

Dec 19, 2025, 5:32:12 PM (2 days ago) Dec 19

to chromium...@chromium.org, net-r...@chromium.org

Nick Harper has uploaded the change for review

Commit message

Add cert_verify_tool option to disable net fetcher.

Change-Id: I3bda3da749bceef45743c94e784f2585d0311329

Change diff

diff --git a/net/tools/cert_verify_tool/cert_verify_tool.cc b/net/tools/cert_verify_tool/cert_verify_tool.cc
index 73b8a470..b68110a 100644
--- a/net/tools/cert_verify_tool/cert_verify_tool.cc
+++ b/net/tools/cert_verify_tool/cert_verify_tool.cc
@@ -399,6 +399,9 @@
     "      Dumps the verified chain to PEM files starting with\n"
     "      <file prefix>.\n"
     "\n"
+    " --no-net-fetcher\n"
+    "      If set, skips performing AIA fetches.\n"
+    "\n"
     "\n"
     "[1] A \"file containing certificates\" means a path to a file that can\n"
     "    either be:\n"
@@ -582,6 +585,10 @@
 
   std::vector<std::unique_ptr<CertVerifyImpl>> impls;
 
+  scoped_refptr<net::CertNetFetcher> passed_net_fetcher = cert_net_fetcher;
+  if (command_line.HasSwitch("no-net-fetcher")) {
+    passed_net_fetcher = nullptr;
+  }
   // Parse the ordered list of CertVerifyImpl passed via command line flags into
   // |impls|.
   std::string impls_str = command_line.GetSwitchValueASCII("impls");
@@ -597,8 +604,8 @@
       impls_str, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
 
   for (const std::string& impl_name : impl_names) {
-    auto verify_impl = CreateCertVerifyImplFromName(impl_name, cert_net_fetcher,
-                                                    crl_set, root_store_type);
+    auto verify_impl = CreateCertVerifyImplFromName(
+        impl_name, passed_net_fetcher, crl_set, root_store_type);
     if (verify_impl)
       impls.push_back(std::move(verify_impl));
   }

Change information

Files:

M net/tools/cert_verify_tool/cert_verify_tool.cc

Change size: S

Delta: 1 file changed, 9 insertions(+), 2 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nick Harper (Gerrit)

unread,

Dec 19, 2025, 5:32:56 PM (2 days ago) Dec 19

to Matt Mueller, chromium...@chromium.org, net-r...@chromium.org

Attention needed from Matt Mueller

Nick Harper voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Matt Mueller

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages