[searchbox] swap out regular searchbox for lens [chromium/src : main]

0 views
Skip to first unread message

James Leung (Gerrit)

unread,
Apr 2, 2026, 5:48:01 PM (3 days ago) Apr 2
to Sho Mizoe, Roman Arora, Dhruv Kathpalia, Duncan Mercer, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
Attention needed from Sho Mizoe

James Leung added 1 comment

File chrome/browser/resources/lens/overlay/lens_overlay_app.ts
Line 501, Patchset 13: // this.searchboxBoundingClientRectObserver.observe(
// this.$.searchbox.getDropdownElement());
Sho Mizoe . resolved

Is this `observe` no longer necessary?

James Leung

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Sho Mizoe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
Gerrit-Change-Number: 7695595
Gerrit-PatchSet: 25
Gerrit-Owner: James Leung <james...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: James Leung <james...@google.com>
Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
Gerrit-CC: Roman Arora <roman...@chromium.org>
Gerrit-Attention: Sho Mizoe <shom...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 21:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sho Mizoe <shom...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

James Leung (Gerrit)

unread,
Apr 2, 2026, 5:48:21 PM (3 days ago) Apr 2
to Sho Mizoe, Roman Arora, Dhruv Kathpalia, Duncan Mercer, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
Attention needed from Duncan Mercer and Sho Mizoe

James Leung added 1 comment

Commit Message
Line 13, Patchset 9:
Duncan Mercer . resolved

Can you please include a screen recording to help verify that everything looks right? Please include both the searchbox in the overlay and the side panel.

James Leung

yes will do

James Leung

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
  • Sho Mizoe
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 25
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Attention: Sho Mizoe <shom...@google.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 21:48:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Duncan Mercer <mer...@google.com>
    Comment-In-Reply-To: James Leung <james...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Duncan Mercer (Gerrit)

    unread,
    Apr 2, 2026, 6:25:38 PM (3 days ago) Apr 2
    to James Leung, Sho Mizoe, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from James Leung and Sho Mizoe

    Duncan Mercer voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • James Leung
    • Sho Mizoe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 25
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Sho Mizoe <shom...@google.com>
    Gerrit-Attention: James Leung <james...@google.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 22:25:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    James Leung (Gerrit)

    unread,
    Apr 2, 2026, 6:27:33 PM (3 days ago) Apr 2
    to Duncan Mercer, Sho Mizoe, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from Sho Mizoe

    James Leung voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sho Mizoe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 25
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Sho Mizoe <shom...@google.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 22:27:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    James Leung (Gerrit)

    unread,
    Apr 2, 2026, 6:34:17 PM (3 days ago) Apr 2
    to Duncan Mercer, Sho Mizoe, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from Sho Mizoe

    James Leung voted Commit-Queue+1

    Commit-Queue+1
    Gerrit-Comment-Date: Thu, 02 Apr 2026 22:34:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Sho Mizoe (Gerrit)

    unread,
    Apr 2, 2026, 8:09:06 PM (3 days ago) Apr 2
    to James Leung, Duncan Mercer, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from James Leung

    Sho Mizoe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • James Leung
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 25
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: James Leung <james...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 00:08:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Sho Mizoe (Gerrit)

    unread,
    Apr 3, 2026, 6:18:12 PM (2 days ago) Apr 3
    to James Leung, Duncan Mercer, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from Duncan Mercer and James Leung

    Sho Mizoe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Duncan Mercer
    • James Leung
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 28
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Attention: James Leung <james...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 22:18:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    James Leung (Gerrit)

    unread,
    Apr 3, 2026, 6:24:48 PM (2 days ago) Apr 3
    to Sho Mizoe, Duncan Mercer, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from Duncan Mercer

    James Leung voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Duncan Mercer
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 28
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 22:24:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Duncan Mercer (Gerrit)

    unread,
    Apr 3, 2026, 7:13:53 PM (2 days ago) Apr 3
    to James Leung, Sho Mizoe, Roman Arora, Dhruv Kathpalia, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from James Leung

    Duncan Mercer voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • James Leung
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 28
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: James Leung <james...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 23:13:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 3, 2026, 7:42:30 PM (2 days ago) Apr 3
    to James Leung, Duncan Mercer, Sho Mizoe, Roman Arora, Dhruv Kathpalia, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mercer...@google.com, lens-chrome...@google.com, stanfie...@google.com, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [searchbox] swap out regular searchbox for lens

    * in side panel and lens overlay, swap out searchbox for
    lens searchbox in css, html, ts, test files
    * delete lens specific items from searchbox
    * fix tests as needed

    Lens searchbox in side panel demo:
    multiple lens selection demo:
    Lens searchbox in lens overlay demo:
    Bug: b:486702737
    Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Commit-Queue: James Leung <james...@google.com>
    Reviewed-by: Sho Mizoe <shom...@google.com>
    Reviewed-by: Duncan Mercer <mer...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1610028}
    Files:
    • M chrome/browser/resources/lens/overlay/lens_overlay_app.html
    • M chrome/browser/resources/lens/overlay/lens_overlay_app.ts
    • M chrome/browser/resources/lens/overlay/side_panel/side_panel_app.html
    • M chrome/browser/resources/lens/overlay/side_panel/side_panel_app.ts
    • M chrome/browser/ui/lens/lens_overlay_controller_browsertest.cc
    • M chrome/browser/ui/lens/lens_overlay_controller_interactive_uitest.cc
    Change size: M
    Delta: 6 files changed, 39 insertions(+), 32 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Duncan Mercer, +1 by Sho Mizoe
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id209a9625a49bf43425b34e5f149b24c55bcf8c1
    Gerrit-Change-Number: 7695595
    Gerrit-PatchSet: 29
    Gerrit-Owner: James Leung <james...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: James Leung <james...@google.com>
    Gerrit-Reviewer: Sho Mizoe <shom...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages