JNI Zero: Remove the std::move exception in the codegen [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Feb 19, 2026, 4:04:01 PM (2 days ago) Feb 19
to Martin Kong, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Martin Kong

Andrew Grieve voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Gerrit-Change-Number: 7595056
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Kong <marti...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Martin Kong <marti...@google.com>
Gerrit-Attention: Martin Kong <marti...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 21:03:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Feb 19, 2026, 4:04:07 PM (2 days ago) Feb 19
to Martin Kong, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Martin Kong

Andrew Grieve voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Gerrit-Change-Number: 7595056
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Kong <marti...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Martin Kong <marti...@google.com>
Gerrit-Attention: Martin Kong <marti...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 21:04:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Feb 19, 2026, 4:04:10 PM (2 days ago) Feb 19
to Martin Kong, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Martin Kong

Andrew Grieve voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Gerrit-Change-Number: 7595056
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Kong <marti...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Martin Kong <marti...@google.com>
Gerrit-Attention: Martin Kong <marti...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 21:04:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Martin Kong (Gerrit)

unread,
Feb 20, 2026, 11:17:42 AM (22 hours ago) Feb 20
to AyeAye, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Andrew Grieve

Martin Kong added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Martin Kong . resolved

Hey Andrew, this CL needs a re-stamp :)

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Gerrit-Change-Number: 7595056
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Kong <marti...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Martin Kong <marti...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 16:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Feb 20, 2026, 11:19:28 AM (22 hours ago) Feb 20
to Martin Kong, Andrew Grieve, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Martin Kong

Andrew Grieve voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Gerrit-Change-Number: 7595056
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Kong <marti...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Martin Kong <marti...@google.com>
Gerrit-Attention: Martin Kong <marti...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 16:19:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 20, 2026, 11:22:38 AM (22 hours ago) Feb 20
to Martin Kong, Andrew Grieve, AyeAye, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, net-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
JNI Zero: Remove the std::move exception in the codegen

We have landed a number of CLs to convert std::blah& to
const std::blah&, so we can now remove the std::move exception
in the JNI Zero codegen.
Bug: 481390486
Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Owners-Override: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587852}
Files:
  • M base/android/command_line_android.cc
  • M chrome/browser/android/httpclient/http_client_bridge.cc
  • M chrome/browser/android/httpclient/http_client_bridge.h
  • M chrome/browser/ui/android/extensions/extension_action_context_menu_bridge.cc
  • M components/cronet/android/test/test_server/embedded_test_server_adapter.cc
  • M components/cronet/android/test/test_server/embedded_test_server_adapter.h
  • M third_party/jni_zero/codegen/natives_header.py
  • M third_party/jni_zero/test/golden/testBidirectionalClass-SampleForTests_jni.h.golden
  • M third_party/jni_zero/test/golden/testEndToEndProxyHashed-SampleForAnnotationProcessor_jni.h.golden
  • M third_party/jni_zero/test/golden/testPackagePrefixGenerator-SampleForTests_jni.h.golden
  • M third_party/jni_zero/test/golden/testPackagePrefixWithFilter-SampleForTests_jni.h.golden
  • M third_party/jni_zero/test/golden/testPerFileNatives-SampleForAnnotationProcessor_jni.h.golden
  • M third_party/jni_zero/test/golden/testUniqueAnnotations-SampleUniqueAnnotations_jni.h.golden
Change size: L
Delta: 13 files changed, 212 insertions(+), 220 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andrew Grieve
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I878a895c324ab64faa1f53b17ab76188e29c0b09
Gerrit-Change-Number: 7595056
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Kong <marti...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Martin Kong <marti...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages