disk_cache: Make CreateNextEntry completion async in perftest [chromium/src : main]
0 views
Skip to first unread message
Tsuyoshi Horo (Gerrit)
Oct 10, 2025, 12:21:08 AM (2 days ago) Oct 10
to Maks Orlovich, Mingyu Lei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Maks Orlovich
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Oct 10, 2025, 10:12:27 AM (2 days ago) Oct 10
to Tsuyoshi Horo, Mingyu Lei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Tsuyoshi Horo
Maks Orlovich voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Oct 10, 2025, 10:30:13 AM (2 days ago) Oct 10
to Maks Orlovich, Mingyu Lei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 10, 2025, 10:32:18 AM (2 days ago) Oct 10
to Tsuyoshi Horo, Maks Orlovich, Mingyu Lei, AyeAye, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
disk_cache: Make CreateNextEntry completion async in perftest
With the in-memory index loaded (crrev.com/c/7023991 ), entry creation
and write operations can complete synchronously. In the perf test, this
causes a deep recursive call chain between CreateNextEntry and its
callback, leading to a stack overflow on Windows.
To fix this, always complete the entry creation asynchronously by
posting a task if it completes synchronously.
Bug: 443171275
Change-Id: Ib030f11456eb82ac735de3aa639155c80ef401ad
Commit-Queue: Tsuyoshi Horo <ho...@chromium.org>
Reviewed-by: Maks Orlovich <morl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528126}
Files:
- M net/disk_cache/disk_cache_perftest.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Maks Orlovich
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages