Hook up Merkle Tree Certificate verification [chromium/src : main]
0 views
Skip to first unread message
Matt Mueller (Gerrit)
Dec 18, 2025, 6:15:48 PM (2 days ago) Dec 18
to Matt Mueller, Nick Harper, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Nick Harper
Matt Mueller added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Matt Mueller . resolved
(marking as ready for review, still depends on https://boringssl-review.googlesource.com/c/boringssl/+/86027 landing so can't do a dry-run yet)
Related details
Attention is currently required from:
- Nick Harper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nick Harper (Gerrit)
Dec 18, 2025, 7:32:55 PM (2 days ago) Dec 18
to Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller
Nick Harper voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nick Harper
| Code-Review | +1 |
1 comment
File net/cert/cert_verify_proc_builtin.cc
Line 540, Patchset 1 (Latest):
// MTCs don't use traditional revocation cecks or certificateNick Harper . unresolved
nit: "checks"
Related details
Attention is currently required from:
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Dec 19, 2025, 11:43:29 AM (2 days ago) Dec 19
to Matt Mueller, Joshua Pawlicki, Chromium LUCI CQ, Nick Harper, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Joshua Pawlicki and Nick Harper
Matt Mueller added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Matt Mueller . resolved
+waffles for chrome/browser/component_updater OWNERS
File net/cert/cert_verify_proc_builtin.cc
Line 540, Patchset 1:
// MTCs don't use traditional revocation cecks or certificateNick Harper . resolved
Matt Muellernit: "checks"
Done
Related details
Attention is currently required from:
- Joshua Pawlicki
- Nick Harper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Dec 19, 2025, 1:52:51 PM (2 days ago) Dec 19
to Matt Mueller, Sorin Jianu, Chromium LUCI CQ, Nick Harper, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Nick Harper and Sorin Jianu
Matt Mueller added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Matt Mueller . resolved
Hi Sorin, looks like waffles@ is now marked as OOO, can you do OWNERS review this instead? thanks!
Related details
Attention is currently required from:
- Nick Harper
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nick Harper (Gerrit)
Dec 19, 2025, 4:05:41 PM (2 days ago) Dec 19
to Matt Mueller, Sorin Jianu, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller and Sorin Jianu
Nick Harper voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Matt Mueller
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Dec 19, 2025, 4:22:59 PM (2 days ago) Dec 19
to Matt Mueller, Nick Harper, Sorin Jianu, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Sorin Jianu
Matt Mueller voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nick Harper (Gerrit)
Dec 19, 2025, 4:31:09 PM (2 days ago) Dec 19
to Matt Mueller, Sorin Jianu, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller and Sorin Jianu
Nick Harper voted![]( "Open in Gerrit")
Attention is currently required from:
- Matt Mueller
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 19, 2025, 4:39:12 PM (2 days ago) Dec 19
to Matt Mueller, Nick Harper, Sorin Jianu, chromium...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Hook up Merkle Tree Certificate verification
Bug: 452986180
Change-Id: Ib12fc995eaded426c6b6b6151810fe334256b5e3
Owners-Override: Nick Harper <nha...@chromium.org>
Reviewed-by: Nick Harper <nha...@chromium.org>
Commit-Queue: Nick Harper <nha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561342}
Files:
- M chrome/browser/component_updater/pki_metadata_component_installer_browsertest.cc
- M net/cert/cert_verify_proc_builtin.cc
- M net/cert/cert_verify_proc_builtin_unittest.cc
- M net/cert/internal/system_trust_store.cc
- M net/cert/internal/system_trust_store.h
- M net/cert/internal/system_trust_store_unittest.cc
- M net/cert/internal/trust_store_chrome.cc
- M net/cert/internal/trust_store_chrome.h
- M net/cert/internal/trust_store_chrome_unittest.cc
- M net/tools/cert_verify_tool/cert_verify_tool.cc
Change size: L
Delta: 10 files changed, 657 insertions(+), 135 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nick Harper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sorin Jianu (Gerrit)
Dec 19, 2025, 5:40:18 PM (2 days ago) Dec 19
to Matt Mueller, Chromium LUCI CQ, Nick Harper, chromium...@chromium.org, net-r...@chromium.org
Sorin Jianu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sorin Jianu
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages