Use CertPathBuilderResultPath.trust_anchor instead of last_cert_trust. [chromium/src : main]

0 views
Skip to first unread message

Nick Harper (Gerrit)

unread,
Dec 19, 2025, 4:54:58 PM (2 days ago) Dec 19
to chromium...@chromium.org, net-r...@chromium.org

Nick Harper has uploaded the change for review

Commit message

Use CertPathBuilderResultPath.trust_anchor instead of last_cert_trust.

The last_cert_trust field is deprecated in favor of trust_anchor.
Change-Id: Idf9180dde4f048bcffa7d0d7680cb2904edd0aa7

Change diff

diff --git a/net/cert/cert_verify_proc_builtin.cc b/net/cert/cert_verify_proc_builtin.cc
index d8a4c40..b0c04da 100644
--- a/net/cert/cert_verify_proc_builtin.cc
+++ b/net/cert/cert_verify_proc_builtin.cc
@@ -211,7 +211,8 @@
     const bssl::CertPathBuilderResultPath& result_path) {
   base::Value::Dict dict;
   dict.Set("is_valid", result_path.IsValid());
-  dict.Set("last_cert_trust", result_path.last_cert_trust.ToDebugString());
+  dict.Set("last_cert_trust",
+           result_path.trust_anchor.CertTrust().ToDebugString());
   dict.Set("certificates", PEMCertValueList(result_path.certs));
   // TODO(crbug.com/40479281): netlog user_constrained_policy_set.
   std::string errors_string =

Change information

Files:
  • M net/cert/cert_verify_proc_builtin.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idf9180dde4f048bcffa7d0d7680cb2904edd0aa7
Gerrit-Change-Number: 7281958
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Harper <nha...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Harper (Gerrit)

unread,
Dec 19, 2025, 4:55:23 PM (2 days ago) Dec 19
to Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller

Nick Harper voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idf9180dde4f048bcffa7d0d7680cb2904edd0aa7
Gerrit-Change-Number: 7281958
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Harper <nha...@chromium.org>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
Gerrit-Attention: Matt Mueller <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 21:55:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Matt Mueller (Gerrit)

unread,
Dec 19, 2025, 5:34:31 PM (2 days ago) Dec 19
to Nick Harper, Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Nick Harper

Matt Mueller voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nick Harper
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf9180dde4f048bcffa7d0d7680cb2904edd0aa7
    Gerrit-Change-Number: 7281958
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nick Harper <nha...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
    Gerrit-Attention: Nick Harper <nha...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 22:34:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 19, 2025, 5:53:08 PM (2 days ago) Dec 19
    to Nick Harper, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Use CertPathBuilderResultPath.trust_anchor instead of last_cert_trust.

    The last_cert_trust field is deprecated in favor of trust_anchor.
    Change-Id: Idf9180dde4f048bcffa7d0d7680cb2904edd0aa7
    Commit-Queue: Matt Mueller <ma...@chromium.org>
    Commit-Queue: Nick Harper <nha...@chromium.org>
    Reviewed-by: Matt Mueller <ma...@chromium.org>
    Auto-Submit: Nick Harper <nha...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1561391}
    Files:
    • M net/cert/cert_verify_proc_builtin.cc
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Matt Mueller
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idf9180dde4f048bcffa7d0d7680cb2904edd0aa7
    Gerrit-Change-Number: 7281958
    Gerrit-PatchSet: 2
    Gerrit-Owner: Nick Harper <nha...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Nick Harper <nha...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages