Revert cflags/ldflags allowlist changes [chromium/src : main]

0 views
Skip to first unread message

Etienne Dechamps (Gerrit)

unread,
Dec 19, 2025, 11:29:43 AM (2 days ago) Dec 19
to Etienne Dechamps, Stefano Duo, Mohannad Farrag, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Mohannad Farrag and Stefano Duo

Etienne Dechamps voted and added 1 comment

Votes added by Etienne Dechamps

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Etienne Dechamps . resolved

Note I have already tested that an import with this CL (1) builds and (2) does not crash on OCSP domains on a real ARM64 device.

Open in Gerrit

Related details

Attention is currently required from:
  • Mohannad Farrag
  • Stefano Duo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02cf0d2701be036d121b05ab58f01132a132fb44
Gerrit-Change-Number: 7277649
Gerrit-PatchSet: 1
Gerrit-Owner: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Stefano Duo <stefa...@google.com>
Gerrit-Attention: Mohannad Farrag <aym...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 16:29:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stefano Duo (Gerrit)

unread,
Dec 19, 2025, 11:56:47 AM (2 days ago) Dec 19
to Etienne Dechamps, Chromium LUCI CQ, Mohannad Farrag, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Dechamps and Mohannad Farrag

Stefano Duo voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Dechamps
  • Mohannad Farrag
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I02cf0d2701be036d121b05ab58f01132a132fb44
    Gerrit-Change-Number: 7277649
    Gerrit-PatchSet: 1
    Gerrit-Owner: Etienne Dechamps <edec...@google.com>
    Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
    Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
    Gerrit-Reviewer: Stefano Duo <stefa...@google.com>
    Gerrit-Attention: Mohannad Farrag <aym...@google.com>
    Gerrit-Attention: Etienne Dechamps <edec...@google.com>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 16:56:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 19, 2025, 2:55:57 PM (2 days ago) Dec 19
    to Etienne Dechamps, Stefano Duo, Mohannad Farrag, chromium...@chromium.org, net-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert cflags/ldflags allowlist changes

    Reason: this causes a crash on ARM64 when accessing hosts that use OCSP
    in their TLS handshake.

    Revert "Add module_prefix to version script files"

    This reverts commit 62202553bfd6abc79feb279d417dd29f28e226bb.

    Revert "Add no-rosegment into denylist"

    This reverts commit 67cded035ec21dbcb79aba041e18e9a099e0643d.

    Revert "Change GN2BP's cflags to a denylist"

    This reverts commit 46bf55723599cc92f2f9c918c65d2b79b4f826f7.

    Revert "Change the ldflags allowlist to a denylist"

    This reverts commit 624ef502fe701782227c75f563697ccba1daa565.
    Bug: b:469760313, b:464490022
    Change-Id: I02cf0d2701be036d121b05ab58f01132a132fb44
    Reviewed-by: Stefano Duo <stefa...@google.com>
    Commit-Queue: Stefano Duo <stefa...@google.com>
    Auto-Submit: Etienne Dechamps <edec...@google.com>
    Commit-Queue: Etienne Dechamps <edec...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1561284}
    Files:
    • M components/cronet/gn2bp/gen_android_bp.py
    • M components/cronet/gn2bp/gn_utils.py
    Change size: M
    Delta: 2 files changed, 45 insertions(+), 135 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stefano Duo
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I02cf0d2701be036d121b05ab58f01132a132fb44
    Gerrit-Change-Number: 7277649
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Dechamps <edec...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
    Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
    Gerrit-Reviewer: Stefano Duo <stefa...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages