Attach failed request details to device bound session events [chromium/src : main]
0 views
Skip to first unread message
thefrog (Gerrit)
Feb 18, 2026, 4:41:28 PM (3 days ago) Feb 18
to Daniel Rubery, Maks Orlovich, Mustafa Emre Acer, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Rubery, Maks Orlovich and Mustafa Emre Acer
thefrog added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
thefrog . resolved
Please review the following:
@dru...@chromium.org: whole CL
@morl...@chromium.org: BUILD.gn
@mea...@chromium.org: mojom files
Related details
Attention is currently required from:
- Daniel Rubery
- Maks Orlovich
- Mustafa Emre Acer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Feb 19, 2026, 2:00:40 PM (2 days ago) Feb 19
to thefrog, Maks Orlovich, Mustafa Emre Acer, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Maks Orlovich, Mustafa Emre Acer and thefrog
Daniel Rubery voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maks Orlovich
- Mustafa Emre Acer
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mustafa Emre Acer (Gerrit)
Feb 19, 2026, 2:08:41 PM (2 days ago) Feb 19
to thefrog, Daniel Rubery, Maks Orlovich, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Maks Orlovich and thefrog
Mustafa Emre Acer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mustafa Emre Acer
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Maks Orlovich
- thefrog
Maks Orlovich (Gerrit)
Feb 19, 2026, 3:37:26 PM (2 days ago) Feb 19
to thefrog, Mustafa Emre Acer, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from thefrog
Maks Orlovich voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 12:27:04 PM (21 hours ago) Feb 20
to thefrog, Maks Orlovich, Mustafa Emre Acer, Daniel Rubery, Alex Ilin, Ali Hijazi, chromium...@chromium.org, druber...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Attach failed request details to device bound session events
These will later be surfaced in DevTools for developer debugging.
Bug: 471017387
Change-Id: Ia9b81e49f0bc0102e302721844c37f5cacb75ab2
Commit-Queue: thefrog <the...@chromium.org>
Reviewed-by: Daniel Rubery <dru...@chromium.org>
Reviewed-by: Mustafa Emre Acer <mea...@chromium.org>
Reviewed-by: Maks Orlovich <morl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587897}
Files:
- M net/device_bound_sessions/session_event.cc
- M net/device_bound_sessions/session_event.h
- M net/device_bound_sessions/session_service_impl.cc
- M net/device_bound_sessions/session_service_impl.h
- M net/device_bound_sessions/session_service_impl_unittest.cc
- M services/network/public/cpp/device_bound_sessions_mojom_traits.cc
- M services/network/public/cpp/device_bound_sessions_mojom_traits.h
- M services/network/public/mojom/BUILD.gn
- M services/network/public/mojom/device_bound_sessions.mojom
Change size: L
Delta: 9 files changed, 251 insertions(+), 46 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Maks Orlovich, +1 by Mustafa Emre Acer, +1 by Daniel Rubery
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages