Gather failed device bound session request details into SessionError [chromium/src : main]
0 views
Skip to first unread message
thefrog (Gerrit)
Feb 18, 2026, 4:41:27 PM (3 days ago) Feb 18
to Daniel Rubery, Maks Orlovich, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Rubery and Maks Orlovich
thefrog added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
thefrog . resolved
Please review the following:
@dru...@chromium.org: whole CL
@morl...@chromium.org: BUILD.gn
Related details
Attention is currently required from:
- Daniel Rubery
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Feb 19, 2026, 1:52:14 PM (2 days ago) Feb 19
to thefrog, Maks Orlovich, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Maks Orlovich and thefrog
Daniel Rubery voted and added 2 comments![]( "Open in Gerrit")
Votes added by Daniel Rubery
| Code-Review | +1 |
2 comments
File net/device_bound_sessions/registration_result.cc
Line 52, Patchset 6 (Latest):
const FailedRequest* RegistrationResult::SessionErrorFailedRequestForTesting()Daniel Rubery . unresolved
Do you anticipate more fields after `failed_request`? If so, maybe we want to go back to one accessor to get the whole `SessionError`, then tests assert on whatever fields they care about.
File net/device_bound_sessions/url_fetcher.h
Line 27, Patchset 6 (Latest):
std::string take_data_received() { return std::move(data_received_); }Daniel Rubery . unresolved
Nit: this isn't a simple accessor so it should be `TakeDataReceived`
Related details
Attention is currently required from:
- Maks Orlovich
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Feb 19, 2026, 2:16:05 PM (2 days ago) Feb 19
to thefrog, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from thefrog
Maks Orlovich voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
thefrog (Gerrit)
Feb 19, 2026, 4:22:28 PM (2 days ago) Feb 19
to Maks Orlovich, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Rubery, Maks Orlovich and thefrog
thefrog added 2 comments![]( "Open in Gerrit")
File net/device_bound_sessions/registration_result.cc
Line 52, Patchset 6:
const FailedRequest* RegistrationResult::SessionErrorFailedRequestForTesting()Daniel Rubery . resolved
Do you anticipate more fields after `failed_request`? If so, maybe we want to go back to one accessor to get the whole `SessionError`, then tests assert on whatever fields they care about.
thefrog
Thanks, I'm not sure we'll have more fields, but there's no need for two anyway. Updated the previous CL and rebased + modified into this one.
File net/device_bound_sessions/url_fetcher.h
Line 27, Patchset 6:
std::string take_data_received() { return std::move(data_received_); }Daniel Rubery . resolved
Nit: this isn't a simple accessor so it should be `TakeDataReceived`
Attention is currently required from:
- Daniel Rubery
- Maks Orlovich
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
thefrog (Gerrit)
Feb 19, 2026, 4:26:43 PM (2 days ago) Feb 19
to Maks Orlovich, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Rubery and Maks Orlovich
thefrog voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Daniel Rubery
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Feb 19, 2026, 4:28:21 PM (2 days ago) Feb 19
to thefrog, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Rubery
Maks Orlovich voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Rubery
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
Feb 19, 2026, 4:28:53 PM (2 days ago) Feb 19
to thefrog, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Rubery and thefrog
Maks Orlovich voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maks Orlovich
| Commit-Queue | +0 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Maks Orlovich . resolved
...Didn't want to +2, want to leave that to you or Daniel...
Related details
Attention is currently required from:
- Daniel Rubery
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
thefrog (Gerrit)
Feb 19, 2026, 7:48:18 PM (2 days ago) Feb 19
to Maks Orlovich, Daniel Rubery, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Maks Orlovich
thefrog voted Auto-Submit+0![]( "Open in Gerrit")
Attention is currently required from:
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Feb 20, 2026, 12:16:43 PM (21 hours ago) Feb 20
to thefrog, AyeAye Python Dispatcher, Maks Orlovich, Alex Ilin, Ali Hijazi, Chromium LUCI CQ, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Attention needed from Maks Orlovich and thefrog
Daniel Rubery voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Rubery
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Maks Orlovich
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 12:25:52 PM (21 hours ago) Feb 20
to thefrog, Daniel Rubery, AyeAye Python Dispatcher, Maks Orlovich, Alex Ilin, Ali Hijazi, chromium...@chromium.org, druber...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Gather failed device bound session request details into SessionError
This CL:
- Continues reading the network response when the response code is not
in [200, 300).
- Populates the new `failed_request` property in SessionError if there
was a network request failure during registration/refresh.
These will later be surfaced in DevTools for developer debugging.
Bug: 471017387
Change-Id: I93ac6f698bb270d99a39918bc7311c2f7eface2d
Reviewed-by: Daniel Rubery <dru...@chromium.org>
Commit-Queue: thefrog <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587895}
Files:
- M net/BUILD.gn
- A net/device_bound_sessions/failed_request.cc
- A net/device_bound_sessions/failed_request.h
- M net/device_bound_sessions/registration_fetcher.cc
- M net/device_bound_sessions/registration_fetcher_unittest.cc
- M net/device_bound_sessions/session_error.h
- M net/device_bound_sessions/url_fetcher.cc
- M net/device_bound_sessions/url_fetcher.h
- M net/device_bound_sessions/url_fetcher_unittest.cc
Change size: M
Delta: 9 files changed, 196 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Rubery
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages