updater: improve IWYU in chrome/updater [chromium/src : main]

0 views

Skip to first unread message

S Ganesh (Gerrit)

unread,

Apr 3, 2026, 7:46:11 PM (2 days ago) Apr 3

to Sorin Jianu, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org

Attention needed from Sorin Jianu

S Ganesh voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Sorin Jianu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Sorin Jianu (Gerrit)

unread,

Apr 3, 2026, 9:12:49 PM (2 days ago) Apr 3

to S Ganesh, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org

Sorin Jianu voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 3, 2026, 9:16:17 PM (2 days ago) Apr 3

to Sorin Jianu, S Ganesh, chromium...@chromium.org, mac-r...@chromium.org, net-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

updater: improve IWYU in chrome/updater

Change-Id: I82ab97449f4ebc5b4561980cc1338543310681cf

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7728029

Commit-Queue: Sorin Jianu <so...@chromium.org>

Reviewed-by: S Ganesh <gan...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1610060}

Files:

M chrome/updater/activity_impl_posix.cc
M chrome/updater/activity_impl_util_linux.cc
M chrome/updater/activity_impl_win.cc
M chrome/updater/app/app.cc
M chrome/updater/app/app_install.cc
M chrome/updater/app/app_install.h
M chrome/updater/app/app_install_win.cc
M chrome/updater/app/app_net_worker.cc
M chrome/updater/app/app_server.cc
M chrome/updater/app/app_server_posix.cc
M chrome/updater/app/app_server_posix_linux.cc
M chrome/updater/app/app_server_posix_mac.cc
M chrome/updater/app/app_uninstall.cc
M chrome/updater/app/app_uninstall_self.cc
M chrome/updater/app/app_unzip_worker.cc
M chrome/updater/app/app_update.cc
M chrome/updater/app/app_update_apps.cc
M chrome/updater/app/app_wake.cc
M chrome/updater/app/app_wakeall.cc
M chrome/updater/app/server/update_service_stub.cc
M chrome/updater/app/server/win/update_service_internal_stub_win.cc
M chrome/updater/app/server/win/update_service_stub_win.cc
M chrome/updater/auto_run_on_os_upgrade_task.cc
M chrome/updater/auto_run_on_os_upgrade_task.h
M chrome/updater/certificate_tag_internal.h
M chrome/updater/change_owners_task.h
M chrome/updater/change_owners_task_posix.cc
M chrome/updater/change_owners_task_win.cc
M chrome/updater/check_for_updates_task.cc
M chrome/updater/check_for_updates_task.h
M chrome/updater/cleanup_task.cc
M chrome/updater/cleanup_task.h
M chrome/updater/configurator.cc
M chrome/updater/crash_client.cc
M chrome/updater/crash_reporter.cc
M chrome/updater/enum_traits.h
M chrome/updater/event_history.cc
M chrome/updater/event_history.h
M chrome/updater/event_history_unittest.cc
M chrome/updater/event_logger.cc
M chrome/updater/event_logger_unittest.cc
M chrome/updater/external_constants.h
M chrome/updater/external_constants_builder.h
M chrome/updater/external_constants_override.cc
M chrome/updater/external_constants_override.h
M chrome/updater/get_updater_scope.cc
M chrome/updater/handle_inconsistent_apps_task.cc
M chrome/updater/handle_inconsistent_apps_task.h
M chrome/updater/installer.cc
M chrome/updater/ipc/ipc_names_linux.cc
M chrome/updater/ipc/proxy_impl_base_win.h
M chrome/updater/ipc/update_service_dialer_mac.cc
M chrome/updater/ipc/update_service_dialer_posix.cc
M chrome/updater/ipc/update_service_dialer_win.cc
M chrome/updater/ipc/update_service_internal_proxy.cc
M chrome/updater/ipc/update_service_internal_proxy_mojo.cc
M chrome/updater/ipc/update_service_internal_proxy_mojo.h
M chrome/updater/ipc/update_service_internal_proxy_win.cc
M chrome/updater/ipc/update_service_internal_proxy_win.h
M chrome/updater/ipc/update_service_proxy_mojo.cc
M chrome/updater/ipc/update_service_proxy_win.cc
M chrome/updater/ipc/update_service_proxy_win.h
M chrome/updater/linux/systemd_util.cc
M chrome/updater/linux/systemd_util.h
M chrome/updater/mac/installer/main.mm
M chrome/updater/mac/keystone/ksadmin.mm
M chrome/updater/mac/keystone/ksadmin_unittest.cc
M chrome/updater/mac/keystone/ksinstall.mm
M chrome/updater/mac/privileged_helper/privileged_helper_unittests.mm
M chrome/updater/mac/privileged_helper/server.h
M chrome/updater/mac/privileged_helper/server.mm
M chrome/updater/mac/privileged_helper/service.h
M chrome/updater/mac/privileged_helper/service.mm
M chrome/updater/mac/setup/mac_setup.mm
M chrome/updater/net/fallback_net_fetcher.cc
M chrome/updater/net/fallback_net_fetcher.h
M chrome/updater/net/fallback_net_fetcher_unittest.cc
M chrome/updater/net/fetcher_callback_adapter.cc
M chrome/updater/net/fetcher_callback_adapter.h
M chrome/updater/net/network.cc
M chrome/updater/net/network.h
M chrome/updater/net/network_fetcher_linux.cc
M chrome/updater/net/network_fetcher_mac.mm
M chrome/updater/net/network_fetcher_win.cc
M chrome/updater/net/network_file_fetcher.h
M chrome/updater/out_of_process_unzipper.cc
M chrome/updater/out_of_process_unzipper.h
M chrome/updater/persisted_data.cc
M chrome/updater/persisted_data.h
M chrome/updater/policy/dm_policy_manager.cc
M chrome/updater/policy/dm_policy_manager_unittest.cc
M chrome/updater/policy/mac/managed_preference_policy_manager.mm
M chrome/updater/policy/manager.cc
M chrome/updater/policy/manager.h
M chrome/updater/policy/policy_fetcher.cc
M chrome/updater/policy/policy_fetcher.h
M chrome/updater/policy/policy_manager.cc
M chrome/updater/policy/policy_manager_unittest.cc
M chrome/updater/policy/service.cc
M chrome/updater/policy/service.h
M chrome/updater/policy/service_unittest.cc
M chrome/updater/policy/win/group_policy_manager.cc
M chrome/updater/policy/win/group_policy_manager_unittest.cc
M chrome/updater/prefs.cc
M chrome/updater/prefs.h
M chrome/updater/remove_uninstalled_apps_task.cc
M chrome/updater/remove_uninstalled_apps_task.h
M chrome/updater/setup_linux.cc
M chrome/updater/setup_mac.mm
M chrome/updater/setup_win.cc
M chrome/updater/tag.cc
M chrome/updater/tag.h
M chrome/updater/test/integration_test_commands.h
M chrome/updater/test/integration_tests.cc
M chrome/updater/test/integration_tests_helper.cc
M chrome/updater/test/server.cc
M chrome/updater/tools/updater_util.cc
M chrome/updater/update_service_impl_impl.cc
M chrome/updater/update_service_impl_impl.h
M chrome/updater/update_service_impl_inactive.cc
M chrome/updater/update_service_internal_impl_qualifying.cc
M chrome/updater/updater.cc
M chrome/updater/usage_stats_permissions.h
M chrome/updater/usage_stats_permissions_linux.cc
M chrome/updater/usage_stats_permissions_mac.mm
M chrome/updater/usage_stats_permissions_win.cc
M chrome/updater/util/linux_util.cc
M chrome/updater/util/path_util.cc
M chrome/updater/util/posix_util.cc
M chrome/updater/util/progress_sampler.cc
M chrome/updater/util/progress_sampler.h
M chrome/updater/util/util.cc
M chrome/updater/util/win_util.cc
M chrome/updater/util/win_util.h
M chrome/updater/util/win_util_unittest.cc
M chrome/updater/win/action_handler.cc
M chrome/updater/win/app_command_runner_unittest.cc
M chrome/updater/win/installer/installer.cc
M chrome/updater/win/installer/string.cc
M chrome/updater/win/installer_api.cc
M chrome/updater/win/manifest_util.cc
M chrome/updater/win/protocol_parser_xml.h
M chrome/updater/win/setup/setup_util_unittest.cc
M chrome/updater/win/task_scheduler.cc
M chrome/updater/win/task_scheduler.h
M chrome/updater/win/test/test_inheritable_event.cc
M chrome/updater/win/test/test_initializer.cc
M chrome/updater/win/ui/complete_wnd.cc
M chrome/updater/win/ui/progress_wnd.cc
M chrome/updater/win/ui/progress_wnd.h
M chrome/updater/win/ui/progress_wnd_unittest.cc
M chrome/updater/win/ui/ui.cc
M chrome/updater/win/ui/ui_util.cc
M chrome/updater/win/ui/webview2_progress_wnd.h
M chrome/updater/win/ui/webview_progress_wnd.cc
M chrome/updater/win/ui/webview_progress_wnd.h

Change size: L

Delta: 156 files changed, 248 insertions(+), 92 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by S Ganesh

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages