disk_cache/backend_unittest.cc: Use TEST_P for multi-backend tests [chromium/src : main]
0 views
Skip to first unread message
Maks Orlovich (Gerrit)
May 29, 2025, 3:11:06 PM5/29/25
to Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Kenichi Ishibashi
Maks Orlovich voted and added 3 comments![]( "Open in Gerrit")
Votes added by Maks Orlovich
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Maks Orlovich . resolved
If you think this is actually useful for you; I'll follow this up with entry_unittest (probably with an intermediate step of pushing the enum to DiskCacheTestBase[WithCache?] and replacing the various methods it has for it with it for consistency)
File net/disk_cache/backend_unittest.cc
Line 2109, Patchset 2:
AddDelay();Line 3359, Patchset 2 (Parent):
// information.Maks Orlovich . unresolved
MOCK_TIME AddDelay did that.
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
May 29, 2025, 7:03:31 PM5/29/25
to Maks Orlovich, Chromium LUCI CQ, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Maks Orlovich
Kenichi Ishibashi voted and added 3 comments![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
3 comments
Patchset-level comments
Kenichi Ishibashi . resolved
lgtm, I like using TEST_P instead of separate helper functions :)
File net/disk_cache/backend_unittest.cc
Line 2109, Patchset 2:
AddDelay();Maks Orlovich . resolved
This is re-litigating https://codereview.chromium.org/118123004/
Kenichi Ishibashi
Acknowledged
Line 3359, Patchset 2 (Parent):
// information.Maks Orlovich . resolved
Kenichi IshibashiMOCK_TIME AddDelay did that.
Acknowledged
Related details
Attention is currently required from:
- Maks Orlovich
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maks Orlovich (Gerrit)
May 30, 2025, 9:59:45 AM5/30/25
to Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Maks Orlovich voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 30, 2025, 10:03:20 AM5/30/25
to Maks Orlovich, Kenichi Ishibashi, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
disk_cache/backend_unittest.cc: Use TEST_P for multi-backend tests
...Rather than doing it by hand with helper functions. The hope is that
if someone were to, say, be working on a different backend, they could
run all tests that are reasonably cross-backend on it easily with just a
few lines of changes. Also centralizes the smaller inconsistencies a
bit.
Change-Id: I99c693a9e401294fec3efcb4274c6f1c1fbffa05
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Commit-Queue: Maks Orlovich <morl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1467452}
Files:
- M net/disk_cache/backend_unittest.cc
Change size: L
Delta: 1 file changed, 139 insertions(+), 253 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kenichi Ishibashi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 1, 2025, 8:18:10 PM6/1/25
to Maks Orlovich, Chromium LUCI CQ, Kenichi Ishibashi, chromium...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tsuyoshi Horo . resolved
Oh, thanks!
Actually I was planing to do the same thing as I'm implementing [a new backend](https://chromium-review.googlesource.com/c/chromium/src/+/6561822).
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages