Revert "updater: testing if the C++23 compiler is real" [chromium/src : main]
0 views
Skip to first unread message
Arthur Eubanks (Gerrit)
Jan 15, 2026, 1:55:44 PMJan 15
to Rubber Stamper, Sorin Jianu, Chromium LUCI CQ, Noah Rose Ledesma, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Attention needed from Sorin Jianu
Arthur Eubanks voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Eubanks (Gerrit)
Jan 15, 2026, 1:58:02 PMJan 15
to Rubber Stamper, Sorin Jianu, Chromium LUCI CQ, Noah Rose Ledesma, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Attention needed from Sorin Jianu
Arthur Eubanks voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Arthur Eubanks (Gerrit)
Jan 15, 2026, 2:00:17 PMJan 15
to Rubber Stamper, Sorin Jianu, Chromium LUCI CQ, Noah Rose Ledesma, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Attention needed from Arthur Eubanks and Sorin Jianu
Arthur Eubanks voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Eubanks
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Arthur Eubanks . resolved
looks like I need code owners stamp
Related details
Attention is currently required from:
- Arthur Eubanks
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noah Rose Ledesma (Gerrit)
Jan 15, 2026, 2:01:24 PMJan 15
to Arthur Eubanks, Rubber Stamper, Sorin Jianu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Attention needed from Arthur Eubanks and Sorin Jianu
Noah Rose Ledesma voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Arthur Eubanks
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sorin Jianu (Gerrit)
Jan 15, 2026, 2:05:21 PMJan 15
to Arthur Eubanks, Noah Rose Ledesma, Rubber Stamper, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Attention needed from Arthur Eubanks
Sorin Jianu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sorin Jianu
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Sorin Jianu . resolved
lgtm ty!
Related details
Attention is currently required from:
- Arthur Eubanks
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 15, 2026, 3:59:49 PMJan 15
to Arthur Eubanks, Sorin Jianu, Noah Rose Ledesma, Rubber Stamper, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "updater: testing if the C++23 compiler is real"
This reverts commit b442fd956e48b68eb18f1ac2494d365ebc52df30.
Reason for revert: clang with assertions crashes on the new code :( https://crbug.com/476129725
Original change's description:
> updater: testing if the C++23 compiler is real
>
> Change-Id: I5a17c0f840e1bd2f5f2c20e489c8e7c99800c77e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7467572
> Auto-Submit: Sorin Jianu <so...@chromium.org>
> Reviewed-by: Noah Rose Ledesma <noah...@google.com>
> Commit-Queue: Noah Rose Ledesma <noah...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1569093}
Change-Id: Ic0e45aae2f508b5edf5309a4ab0862005808c8bc
Auto-Submit: Arthur Eubanks <aeub...@google.com>
Reviewed-by: Sorin Jianu <so...@chromium.org>
Commit-Queue: Sorin Jianu <so...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Noah Rose Ledesma <noah...@google.com>
Cr-Commit-Position: refs/heads/main@{#1569965}
Files:
- M chrome/updater/app/app_install.cc
- M chrome/updater/net/network_fetcher_mac.mm
- M chrome/updater/update_service_impl_impl.cc
- M chrome/updater/updater.cc
- M chrome/updater/util/win_util.cc
Change size: S
Delta: 5 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sorin Jianu, +1 by Noah Rose Ledesma, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Feb 16, 2026, 9:12:56 PM (5 days ago) Feb 16
to Chromium LUCI CQ, Arthur Eubanks, Nico Weber, Sorin Jianu, Noah Rose Ledesma, Rubber Stamper, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Nico Weber added 1 comment![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noah Rose Ledesma (Gerrit)
Feb 20, 2026, 3:55:58 PM (2 days ago) Feb 20
to Chromium LUCI CQ, Arthur Eubanks, Nico Weber, Sorin Jianu, Rubber Stamper, AyeAye, chromium...@chromium.org, net-r...@chromium.org, mac-r...@chromium.org
Noah Rose Ledesma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nico Weber . resolved
I think this can reland now.
Noah Rose Ledesma
Thanks for following up! The trailing decltype was removed in crrev.com/c/7486605 while the other changes from this CL were relanded in crrev.com/c/7489300.
Reply all
Reply to author
Forward
0 new messages