Remove Net.DNS.DnsTask.AdditionalHttps.Unsolicited [chromium/src : main]

0 views
Skip to first unread message

Andrew Williams (Gerrit)

unread,
Dec 18, 2025, 12:54:12 PM (3 days ago) Dec 18
to Nidhi Jaju, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, net-r...@chromium.org
Attention needed from Nidhi Jaju

Andrew Williams added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Andrew Williams . resolved

Hi Nidhi, PTAL. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Nidhi Jaju
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4116744bfdac5b3199428b98ec1b48f7153e9552
Gerrit-Change-Number: 7276186
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 17:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nidhi Jaju (Gerrit)

unread,
Dec 18, 2025, 11:54:54 PM (2 days ago) Dec 18
to Andrew Williams, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, net-r...@chromium.org
Attention needed from Andrew Williams

Nidhi Jaju voted and added 1 comment

Votes added by Nidhi Jaju

Code-Review+1

1 comment

Patchset-level comments
Nidhi Jaju . resolved

lgtm, thanks for the cleanup!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Williams
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4116744bfdac5b3199428b98ec1b48f7153e9552
Gerrit-Change-Number: 7276186
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Andrew Williams <awi...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 04:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Williams (Gerrit)

unread,
Dec 19, 2025, 9:13:04 AM (2 days ago) Dec 19
to Nidhi Jaju, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, net-r...@chromium.org

Andrew Williams voted and added 1 comment

Votes added by Andrew Williams

Commit-Queue+2

1 comment

Patchset-level comments
Andrew Williams . resolved

Thanks Nidhi!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4116744bfdac5b3199428b98ec1b48f7153e9552
Gerrit-Change-Number: 7276186
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 14:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 19, 2025, 9:16:27 AM (2 days ago) Dec 19
to Andrew Williams, Nidhi Jaju, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, net-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove Net.DNS.DnsTask.AdditionalHttps.Unsolicited

It doesn't seem like we need this data anymore

OBSOLETE_HISTOGRAM[Net.DNS.DnsTask.AdditionalHttps.Unsolicited]=Data no longer needed
Fixed: 400444411
Change-Id: I4116744bfdac5b3199428b98ec1b48f7153e9552
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Commit-Queue: Andrew Williams <awi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561110}
Files:
  • M net/dns/dns_response_result_extractor.cc
  • M tools/metrics/histograms/metadata/net/enums.xml
  • M tools/metrics/histograms/metadata/net/histograms.xml
Change size: S
Delta: 3 files changed, 17 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nidhi Jaju
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4116744bfdac5b3199428b98ec1b48f7153e9552
Gerrit-Change-Number: 7276186
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages