webrtc: fix L4S / ECN send on Windows [chromium/src : main]

0 views

Skip to first unread message

Philipp Hancke (Gerrit)

unread,

Feb 20, 2026, 6:44:24 AM (yesterday) Feb 20

to Ryan Hamilton, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org

Attention needed from Ryan Hamilton

Philipp Hancke added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Philipp Hancke . resolved

ryan: can you please take a look?

I pondered whether to change the VerifyDscpAndEcnExchangeV4 test but it looked like a mess on Windows. Something along the lines of https://chromium-review.googlesource.com/c/chromium/src/+/7595259 which currently fails but would pass after this change seemed overkill.

Sadly we don't have WPT for the WebRTC behavior yet since it is still gated behind feature flags.

File net/socket/udp_socket_win.cc

Line 1174, Patchset 2 (Latest): rv = bytes_sent;

Philipp Hancke . unresolved

drive-by name fix. I also noticed that this is very similar to the code around line 1050 but lacks the temp_address handling?

Open in Gerrit

Related details

Attention is currently required from:

Ryan Hamilton

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Philipp Hancke (Gerrit)

unread,

Feb 20, 2026, 12:26:40 PM (21 hours ago) Feb 20

to Martin Duke, Ryan Hamilton, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org