[DBSC] Support in-refresh challenges in browser tests [chromium/src : main]
Alex Ilin (Gerrit)
Alex Ilin added 1 comment![]( "Open in Gerrit")
Daniel, could you PTAL? This is a prep CL as I noticed some gaps in DBSC browser tests.
Related details
- Daniel Rubery
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Daniel Rubery voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Rubery
| Code-Review | +1 |
1 comment
bool is_refresh = request.relative_url.starts_with("/dbsc_refresh_session");Meta-point: At some point the number of query params is going to get unreadable. There's no reason this function has to be stateless. We might be able to have a `TestSessionServer` object that we use to configure the sessions instead.
Related details
- Alex Ilin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Alex Ilin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alex Ilin
| Commit-Queue | +2 |
2 comments
Thank you!
bool is_refresh = request.relative_url.starts_with("/dbsc_refresh_session");Meta-point: At some point the number of query params is going to get unreadable. There's no reason this function has to be stateless. We might be able to have a `TestSessionServer` object that we use to configure the sessions instead.
Ack. Prototype browser tests [1] have something like this.
Their set-up is a bit awkward because DBSC-prototype makes some requests on startup so the server state must be passed during the test initialization [2]. Also, the test server runs on its own thread, so the initialization at startup helps avoid synchronization issues.
`EmbeddedTestServer` doesn't publicly expose an API to post tasks on the server's thread, so it will be tricky to control its state once the server has started. There is a `PostTaskToIOThreadAndWait()` function but it's private [3].
[1] https://crsrc.org/c/chrome/browser/signin/bound_session_credentials/bound_session_cookie_refresh_service_impl_browsertest.cc;drc=0997588bfa4fb50d4a030cba70b93ae42e9ded30;l=261
[2] https://crsrc.org/c/chrome/browser/signin/bound_session_credentials/bound_session_cookie_refresh_service_impl_browsertest.cc;drc=91fbe18b2afd81017d9b260a44a6f5491efe2f71;l=684
[3] https://crsrc.org/c/net/test/embedded_test_server/embedded_test_server.h;drc=91fbe18b2afd81017d9b260a44a6f5491efe2f71;l=784
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |