--
You received this message because you are subscribed to the Google Groups "navigation-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to navigation-de...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CALMy46TsDeiun_2H7dXLSdj589p3MEmA-WzH5n0fEEcOkfqOcQ%40mail.gmail.com.
Good question. We’re only concerned about main frame navigations in this case, so they would likely be the same for us.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CALMy46RKo2fQzLk8LXck2PPUT%3D8sj-5aznrZam98%3DU0KxvHe4A%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CAHtyhaQ6iiOczQaMkLCRzGjaZPYinTaDKZn%2BTQ6N23DtVoWk1Q%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CALMy46QFRtnmzKbjaC6XWwJN%3DXxP7RpBsf9Q6js%3D3h5Fj34ing%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CALHg4nko-GQx27SP-ozUthNwqoGFq7tKVCQhjmMN7HgpueTssQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CAA_NCUFuewwvAxS2-pmfn3GtcM%3DZ8iQ95QxF-KfHxKoH%2B0wzXA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/navigation-dev/CALMy46RQY-JgSTSLK1J4gKPZPdjiTvXzFBGCCUL%3DWAHkbtsOFw%40mail.gmail.com.
You received this message because you are subscribed to the Google Groups "net-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to net-dev+u...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/net-dev/CALMy46TzFeUhi8st0fXURM6JsTG_VdRwGO%3DNVWZJjuybeN3vbw%40mail.gmail.com.
Thanks Matt! And agreed that NavigationURLLoader seems like a reasonable layer to add navigation-level timeout functionality. However, for our purposes I don't think we can make this timeout an argument passed to the Loader when it's being created, as the navigation (and loader) already exist when the navigation gets upgraded -- maybe there's a reasonable way to "swap out" an existing navigation (loader) I'm not thinking of?I've updated my proof-of-concept CL to use a quick implementation of this (see PS#5 https://crrev.com/c/3149506/5) where instead we expose the timeout via a method on NavigationHandle/NavigationURLLoader:
- Adds NavigationURLLoader::SetNavigationTimeout() which starts a OneShotTimer for the specified duration, which calls OnComplete(ERR_TIMED_OUT) when triggered.
- Adds NavigationHandle::SetNavigationTimeout() to give an API which Throttles can call to set the timeout. This gets forwarded through to the Loader for the NavigationRequest.
Currently these methods return a boolean for whether the timeout was started or not (and they don't reset the timer if called multiple times) to make it easier to integrate them into the existing logic in HttpsOnlyModeNavigationThrottle -- it might be possible to avoid this with some more changes to our Throttle code.Let me know if this seems like a reasonable approach to handling this at this layer.